Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sample.LocationsLength is mis calculated #262

Closed
dmathieu opened this issue Dec 5, 2024 · 1 comment
Closed

sample.LocationsLength is mis calculated #262

dmathieu opened this issue Dec 5, 2024 · 1 comment
Assignees
@florianl
Labels
bug Something isn't working

Comments

@dmathieu
Copy link
Member

dmathieu commented Dec 5, 2024 

          This is incorrect, as frames of type `libpf.AbortFrame` are skipped. The correct value would be the number of interpreted frames + number of native frames.

But I think this is also a bug in the current implementation.

Originally posted by @florianl in #245 (comment)
@dmathieu dmathieu mentioned this issue Dec 5, 2024
Merged
florianl added a commit that referenced this issue Jan 21, 2025
@florianl
reporter: fix samples.SetLocationsLength
f3abf76 
Fixes #262

Signed-off-by: Florian Lehner <[email protected]>
@florianl florianl mentioned this issue Jan 21, 2025
Closed
@florianl florianl self-assigned this Jan 21, 2025
@florianl florianl added the bug Something isn't working label Jan 21, 2025
@florianl
Copy link
Contributor

After revisiting this, #245 (comment) was not entierly correct - see #317 (comment).
Therefore closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@florianl florianl

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

reporter: fix samples.SetLocationsLength open-telemetry/opentelemetry-ebpf-profiler
2 participants
@dmathieu @florianl