New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused HostID #176

Closed

rockdaboot opened this issue Oct 9, 2024 · 1 comment

Labels

cleanup

Contributor

rockdaboot commented Oct 9, 2024

If I see it correctly, we don't need to send host.id any more because it is unset (always "0").

reporter/config.go
31:     // HostID is the host ID to be sent to the collection agent.
32:     HostID uint64

reporter/otlp_reporter.go
137:    // hostID is the unique identifier of the host.
138:    hostID string
333:            hostID:                  strconv.FormatUint(cfg.HostID, 10),
471:    addAttr(semconv.HostIDKey, r.hostID)

The text was updated successfully, but these errors were encountered:

rockdaboot added the cleanup label

Contributor Author

rockdaboot commented Oct 10, 2024

Closing in favor of #178

rockdaboot closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment