Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Instrument Advisory Parameter for ExplicitHistogram Buckets #5166

Closed
cijothomas opened this issue Dec 13, 2023 · 2 comments
Closed
Labels
enhancement New feature or request needs-runtime-change Issues which likely require changes from dotnet runtime - typically DiagnosticSource package

Comments

@cijothomas
Copy link
Member

Add support for Instrument Advisory Parameter for ExplicitHistogram buckets
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/api.md#instrument-advisory-parameter-explicitbucketboundaries

@cijothomas cijothomas added enhancement New feature or request needs-runtime-change Issues which likely require changes from dotnet runtime - typically DiagnosticSource package labels Dec 13, 2023
@JamesNK
Copy link
Contributor

JamesNK commented Jun 28, 2024

PR for annotating ASP.NET Core metrics: dotnet/aspnetcore#56500
Issue for doing the same in dotnet/runtime: dotnet/runtime#104137

As part of this work, opentelemetry-dotnet in .NET 9 or greater should use advisory values instead of the hack here:

internal static readonly HashSet<(string, string)> DefaultHistogramBoundShortMappings = new()
{
("Microsoft.AspNetCore.Hosting", "http.server.request.duration"),
("Microsoft.AspNetCore.RateLimiting", "aspnetcore.rate_limiting.request.time_in_queue"),
("Microsoft.AspNetCore.RateLimiting", "aspnetcore.rate_limiting.request_lease.duration"),
("Microsoft.AspNetCore.Server.Kestrel", "kestrel.tls_handshake.duration"),
("OpenTelemetry.Instrumentation.AspNet", "http.server.request.duration"),
("OpenTelemetry.Instrumentation.AspNetCore", "http.server.request.duration"),
("OpenTelemetry.Instrumentation.Http", "http.client.request.duration"),
("System.Net.Http", "http.client.request.duration"),
("System.Net.Http", "http.client.request.time_in_queue"),
("System.Net.NameResolution", "dns.lookup.duration"),
};

@cijothomas
Copy link
Member Author

closed via #5854

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-runtime-change Issues which likely require changes from dotnet runtime - typically DiagnosticSource package
Projects
None yet
Development

No branches or pull requests

2 participants