Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to add s3 credentials #6

Open
lbradstreet opened this issue Dec 15, 2016 · 4 comments
Open

Document how to add s3 credentials #6

lbradstreet opened this issue Dec 15, 2016 · 4 comments

Comments

@lbradstreet
Copy link
Member

No description provided.

@fl00r
Copy link

fl00r commented Feb 13, 2017

For those, who are interested in this as well and have found only this issue

https://github.com/onyx-platform/onyx-amazon-s3/blob/0.10.x/src/onyx/s3/information_model.cljc#L11-L17

@MichaelDrogalis
Copy link
Contributor

Most of the time you're going to want to use the AWS SDK ProviderChain to grab these from environment variables. Going through the catalog is somewhat of an escape hatch for when you can't use the env - it's less ideal because you're pushing credentials into ZooKeeper.

@fl00r
Copy link

fl00r commented Feb 13, 2017

I generally don't like the idea to access environment variables here and there. I prefer to capture all of them in my config and to pass them explicitly further.

@fl00r
Copy link

fl00r commented Feb 13, 2017

But your point about ZooKeeper is valid and important if you are exposing your ZooKeeper out of your private network.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants