Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

top/bottom column calculations do not work with renderHorizontal: "virtual" #4669

Open
andy-5 opened this issue Jan 17, 2025 · 2 comments
Open
Labels
Possible Bug A possible bug that needs investigation

Comments

@andy-5
Copy link

andy-5 commented Jan 17, 2025

Describe the bug
The top/bottom column calculations do not work correctly with the setting renderHorizontal: "virtual".
For columns that are lazily loaded, nothing is computed and no field is shown in the top/bottom calc rows.

Disabling virtual rendering of columns fixes the problem.

Tabulator Info
Tabulator 6.3

Working Example
https://jsfiddle.net/Lpdav9r8/22/

To Reproduce

  1. Go to https://jsfiddle.net/Lpdav9r8/22/
  2. Scroll to the right of the generated table
  3. Observe that no column calculation results are shown for columns "Progress", "Rating", "Driver"

Workarounds to get the expected calculations

  • Remove the setting renderHorizontal: "virtual",

or

  • Remove the indicated dummy columns {title:"ID", field:"id", width:500},
    (columns are not loaded lazily in that case, and calculation works)

Expected behavior
The column calculations should be shown also for lazily loaded columns with renderHorizontal: "virtual",.

Desktop:

  • OS: Windows
  • Browser: Firefox
  • Version: 134.0.1
@andy-5 andy-5 added the Possible Bug A possible bug that needs investigation label Jan 17, 2025
@olifolkerd
Copy link
Owner

olifolkerd commented Jan 19, 2025

Hey @andy-5

That is correct, column calculations are currently listed as incompatible with horizontal virtual dom in the documentation:

Image

Cheers

Oli :)

@andy-5
Copy link
Author

andy-5 commented Jan 20, 2025

Ah, thanks for the tip, I must have overlooked that in the documentation.

But it seems the automatic disabling of the horizontal virtual DOM does not work if the setting is explicitly enabled in the config, as in my example above.

Should I keep this issue open? For me its fine to close it, as it works (almost) as documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Possible Bug A possible bug that needs investigation
Projects
None yet
Development

No branches or pull requests

2 participants