Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated useSlug with usePathParams and classNames with cn utility #9939

Closed
rajku-dev opened this issue Jan 13, 2025 · 2 comments
Closed

Replace deprecated useSlug with usePathParams and classNames with cn utility #9939

rajku-dev opened this issue Jan 13, 2025 · 2 comments

Comments

@rajku-dev
Copy link
Contributor

rajku-dev commented Jan 13, 2025 •
edited
Loading

Image

Image

Replace all usages of deprecated classNames and useSlug with cn and usePathParams respectively.
@rajku-dev
Copy link
Contributor Author

I would like to take on this task.

@rajku-dev rajku-dev changed the title Replace deprecated classNames with cn utility Replace deprecated useSlug with usePathParams and classNames with cn utility Jan 13, 2025
@rithviknishad rithviknishad closed this as not planned Won't fix, can't repro, duplicate, stale Jan 14, 2025
@rithviknishad
Copy link
Member

rithviknishad commented Jan 14, 2025 •
edited
Loading

  • useSlug's alternative: usePathParams comes from raviger, which we are planning to replace with tanstack router soon in Switch to @tanstack/react-router #9920, and a different approach would be needed to solve that.

  • classNames can be done later as 70% of the usages will go away by removing the deprecated components itself in the first place.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rithviknishad @rajku-dev