Remove duplicate age

[rajku-dev]

Proposed Changes

• Fixes Incorrect Patient Age displayed on Appointment page #9922
• Removed rendering age two times

BEFORE

AFTER

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

• Add specs that demonstrate bug / test a new feature.
• Update product documentation.
• Ensure that UI text is kept in I18n files.
• Prep screenshot or demo video for changelog entry, and attach it to issue.
• Request for Peer Reviews
• Completion of QA

Summary by CodeRabbit

• UI/UX Improvements
  • Simplified patient information display in Appointment Details
  • Updated age and date of birth presentation to be more concise and readable

[coderabbitai]

Walkthrough

The pull request modifies the AppointmentDetail.tsx file to simplify the display of patient age and date of birth. The changes remove the explicit rendering of the patient's year of birth and streamline the age presentation. The component now displays the patient's date of birth formatted in a standard date format, followed by their calculated age, separated by a pipe character.

Changes

File	Change Summary
src/pages/Appointments/AppointmentDetail.tsx	Simplified patient age and date of birth display, removing year of birth rendering

Assessment against linked issues

Objective	Addressed	Explanation
Correct Patient Age Display [#9922]	✅

Possibly related PRs

• Patients age is correctly defined #9680: Changes to formatPatientAge function related to age calculation

Suggested labels

tested, reviewed

Suggested reviewers

• rithviknishad

Poem

🐰 A Rabbit's Ode to Age Display 🎂

Bits of code, once verbose and wide,
Now trimmed with elegance and pride
Patient's age, no longer cluttered
A simple line, perfectly uttered
Hop, hop, hooray for clean design! 🎉

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[netlify]

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	b3be81c
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/6784d2242c32f1000828f72a
😎 Deploy Preview	https://deploy-preview-9928--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/pages/Appointments/AppointmentDetail.tsx (1)

294-295: LGTM! Consider these minor improvements

The changes successfully remove the duplicate age display while maintaining a clean and readable format. Two suggestions for enhancement:

1. Consider moving the years translation into the age display for better readability:

-                    {differenceInYears(
-                      new Date(),
-                      appointment.patient.date_of_birth!,
-                    )}
-                  </>
-                )}{" "}
-                {t("years")}
+                    {`${differenceInYears(
+                      new Date(),
+                      appointment.patient.date_of_birth!,
+                    )} ${t("years")}`}
+                  </>
+                )}

2. Add an aria-label for better accessibility:

-              <p className="text-gray-600">
+              <p className="text-gray-600" aria-label={`${t("date_of_birth_and_age")}`}>

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 19239d5 and b3be81c.

📒 Files selected for processing (1)

• src/pages/Appointments/AppointmentDetail.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: cypress-run (1)

[Jacobjeevan]

So, patient can register with either year of birth or date of birth. If they fill out date of birth, BE will automatically populate year of birth as well.

If they only provide year of birth, date of birth will be unpopulated. So you will have to add this back and only trigger it if date of birth isn't available.