Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appointment data is not displayed properly #9903

Closed
manmeetnagii opened this issue Jan 11, 2025 · 7 comments · Fixed by #10204 · May be fixed by #9920
Closed

Appointment data is not displayed properly #9903

manmeetnagii opened this issue Jan 11, 2025 · 7 comments · Fixed by #10204 · May be fixed by #9920
Assignees

Comments

@manmeetnagii
Copy link
Contributor

Describe the bug
The data on the appointment page does not display properly when we first navigate to it. However, it displays correctly after clicking the appointment tab again.

To Reproduce
Steps to reproduce the behavior:

Screen.Recording.2025-01-11.202632.mp4
@manmeetnagii
Copy link
Contributor Author

Same behaviour in list view also

@Jomi-0
Copy link

Jomi-0 commented Jan 11, 2025

May I be assigned this github issue? Thank you

@github-actions github-actions bot added needs-triage question Further information is requested labels Jan 11, 2025
@rithviknishad
Copy link
Member

it works as expected. just that the default filters change on clicking the tab again.

@Jomi-0
Copy link

Jomi-0 commented Jan 11, 2025

Would it be ok if I changed the default filter to "Pick a date" before we have to re-click appointments? If it is supposed to filter by today, would it be good to keep the today filter after the appointments tab is clicked again?

@rithviknishad
Copy link
Member

let's not change any of that.

instead we shouldn't be changing any of the already applied filters (whether default or not) on the second click.

@Jomi-0
Copy link

Jomi-0 commented Jan 11, 2025

Ok, I understand. I don't think the filter resetting after re-clicking appointments is an Issue but I could fix it if you would like.

@rithviknishad rithviknishad removed question Further information is requested needs-triage labels Jan 11, 2025
@rithviknishad rithviknishad assigned Jomi-0 and rithviknishad and unassigned Jomi-0 Jan 11, 2025
@rithviknishad
Copy link
Member

rithviknishad commented Jan 13, 2025

taking over due to no activity, and also this would be solved along with tanstack router migration as it's easier to achieve the desired solution using that

#9920

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants