src/pages/Organization/OrganizationPatients.tsx (1)

41-52: Consider improving phone number validation.

The phone number validation logic could be more robust:

1. The magic number 13 should be extracted as a constant for better maintainability.
2. The validation should consider minimum length requirements for different phone number formats.

Apply this diff to improve the validation:

+const MIN_PHONE_LENGTH = 13;
+
 const handleSearch = useCallback((key: string, value: string) => {
   const searchParams = {
     name: key === "name" ? value : "",
     phone_number:
       key === "phone_number"
-        ? value.length >= 13 || value === ""
+        ? value.length >= MIN_PHONE_LENGTH || value === ""
           ? value
           : undefined
         : undefined,
   };
   updateQuery(searchParams);
 }, []);

src/components/Common/SearchByMultipleFields.tsx (2)

191-214: Reduce code duplication in keyboard shortcut hints.

The keyboard shortcut hint UI is duplicated between the phone number input and text input sections. Consider extracting it into a reusable component.

Create a new component for the keyboard hints:

const KeyboardShortcutHint: React.FC<{ isOpen: boolean }> = ({ isOpen }) => {
  if (isOpen) {
    return (
      <span className="border border-gray-300 rounded px-1 py-0.5 bg-white text-gray-500">
        ESC
      </span>
    );
  }
  
  return (
    <span>
      {isAppleDevice ? (
        <span className="border border-gray-300 rounded px-1 py-0.5 bg-white text-gray-500">
          ⌘K
        </span>
      ) : (
        <div className="flex gap-1 font-medium">
          <span className="border border-gray-300 rounded px-1 py-0.5 bg-white text-gray-500">
            Ctrl
          </span>
          <span className="border border-gray-300 rounded px-1 py-0.5 bg-white text-gray-500">
            K
          </span>
        </div>
      )}
    </span>
  );
};

Then use it in both places:

 <div className="absolute top-1/2 right-2 transform -translate-y-1/2 flex items-center space-x-2 text-xs text-gray-500">
-  {open ? (
-    <span className="border border-gray-300 rounded px-1 py-0.5 bg-white text-gray-500">
-      ESC
-    </span>
-  ) : (
-    <span>
-      {isAppleDevice ? (
-        <span className="border border-gray-300 rounded px-1 py-0.5 bg-white text-gray-500">
-          ⌘K
-        </span>
-      ) : (
-        <div className="flex gap-1 font-medium">
-          <span className="border border-gray-300 rounded px-1 py-0.5 bg-white text-gray-500">
-            Ctrl
-          </span>
-          <span className="border border-gray-300 rounded px-1 py-0.5 bg-white text-gray-500">
-            K
-          </span>
-        </div>
-      )}
-    </span>
-  )}
+  <KeyboardShortcutHint isOpen={open} />
 </div>

Also applies to: 226-249

---

130-140: Enhance keyboard navigation robustness.

The keyboard navigation logic could be improved in two areas:

1. Add visual feedback when no item is focused (focusedIndex === -1)
2. Make the Enter key handler more defensive

Apply these improvements:

 } else if (e.key === "Enter" && focusedIndex !== -1) {
+  if (focusedIndex >= unselectedOptions.length) {
+    return;
+  }
   const selectedOptionIndex = options.findIndex(
     (option) => option.key === unselectedOptions[focusedIndex].key,
   );
+  if (selectedOptionIndex === -1) {
+    return;
+  }
   handleOptionChange(selectedOptionIndex);
 }

Also, consider adding a CSS class to indicate when no item is focused:

 className={cn(
   "flex items-center p-2 rounded-md cursor-pointer",
   {
     "bg-gray-100": focusedIndex === index,
+    "bg-gray-50": focusedIndex === -1,
     "hover:bg-secondary-100": true,
   },
 )}

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

src/components/Common/SearchByMultipleFields.tsx (4)

117-125: Document the new keyboard shortcut

The change from "/" to "Cmd/Ctrl + K" is a good improvement, but should be documented for users.

Consider adding a comment explaining the shortcut change:

+// Using Cmd/Ctrl + K as it's a more standard shortcut for search functionality
 if (e.key === "k" && (e.metaKey || e.ctrlKey)) {

---

155-159: Improve phone number validation logic

The phone number validation logic could be more robust. Consider extracting the validation to a separate function.

+const isValidPhoneNumber = (value: string) => value.length === 13 || value.length === 3;
+
 if (
-  selectedOption.key === "phone_number"
-    ? searchValue.length == 13 || searchValue.length == 3
-    : selectedOption.value !== searchValue
+  selectedOption.key === "phone_number"
+    ? isValidPhoneNumber(searchValue)
+    : selectedOption.value !== searchValue
 ) {

---

397-409: Add data-testid for clear search button

The clear search button is a good addition, but should include a data-testid for testing.

 <Button
   variant="ghost"
   size="sm"
+  data-testid={`${id}__clear-search`}
   className="w-full justify-start text-muted-foreground"
   onClick={() => {
     setSearchValue("");
   }}
 >

---

281-292: Enhance accessibility with ARIA labels

While the basic ARIA implementation is good, consider adding more descriptive labels.

 <Button
   variant="ghost"
   className="focus:ring-0 px-2 ml-1"
   size="sm"
+  aria-label={t("open_search_options")}
   onClick={() => setOpen(true)}
 >

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

src/components/Common/SearchByMultipleFields.tsx (2)

117-124: Consider adding ARIA attributes for keyboard shortcuts

While the keyboard shortcut implementation is good, consider adding ARIA attributes to improve accessibility.

+  aria-keyshortcuts="Control+K"

---

391-403: Consider adding keyboard shortcut for clear search

The clear search button is a good addition, but consider adding a keyboard shortcut (e.g., Esc when the input is focused) for better user experience.

 useEffect(() => {
   const handleKeyDown = (e: KeyboardEvent) => {
+    if (e.key === "Escape" && document.activeElement === inputRef.current) {
+      setSearchValue("");
+      return;
+    }
     // ... existing code
   };
 }, []);

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

src/components/Users/UserResetPassword.tsx (2)

228-231: Consider adding loading spinner for better UX.

While the button text changes to "updating", consider adding a loading spinner icon for better visual feedback.

 <Button
   type="submit"
   disabled={!form.formState.isDirty || isPending}
   variant="primary"
 >
+  {isPending && <CareIcon icon="l-spinner" className="mr-2 h-4 w-4 animate-spin" />}
   {isPending ? t("updating") : t("update_password")}
 </Button>

---

Line range hint 41-137: Consider rate limiting password attempts.

The password reset functionality could benefit from rate limiting to prevent brute force attempts. Consider implementing a mechanism to track failed attempts and temporarily lock the account after a certain threshold.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro