Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Shadcn Date Time Component #9618

Closed
2 tasks
saikiranpatil opened this issue Dec 31, 2024 · 5 comments
Closed
2 tasks

Using Shadcn Date Time Component #9618

saikiranpatil opened this issue Dec 31, 2024 · 5 comments
Labels
needs-triage question Further information is requested

Comments

@saikiranpatil
Copy link

Is your feature request related to a problem? Please describe.
Issues similar as described in #8994

  • Regardless of the user's system time preference, the text field displays time in 24-hour format, while the selection component defaults to a 12-hour format. This inconsistent behavior is not ideal for a component.
  • It is not possible to input "01" in the minutes part of the component; the input text area always shows "1," automatically removing the "0" for single-digit entries.

Describe the solution you'd like
As most of the components are migrating to shadcn, we could utlize Shadcn Date Time Picker Code and modify it as per our requirement. This would solve most of the date time component bugs.

@saikiranpatil
Copy link
Author

@ohcnetwork/care-fe-code-reviewers
if this issue is valid, assign this to me

@rajku-dev
Copy link
Contributor

@saikiranpatil did you tried rendering shadcn Calendar? Its css is little broken in my case.
Image

@github-actions github-actions bot added needs-triage question Further information is requested labels Dec 31, 2024
@saikiranpatil
Copy link
Author

@saikiranpatil did you tried rendering shadcn Calendar? Its css is little broken in my case.

not sure from where you are trying this from

@rajku-dev
Copy link
Contributor

https://ui.shadcn.com/docs/components/calendar
datepicker you mentioned in issue description uses the same Calendar component from ShadCN UI

@saikiranpatil did you tried rendering shadcn Calendar? Its css is little broken in my case.

not sure from where you are trying this from

@rithviknishad
Copy link
Member

We already have these, which is sufficient.

Image

@rithviknishad rithviknishad closed this as not planned Won't fix, can't repro, duplicate, stale Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants