-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign the header to be consistent across all pages #7316
Comments
@sainak @rithviknishad can you please assign this issue to me |
@saloni0419 wait for a thumbs up from @aparnacoronasafe |
Sure |
I would like to work on this issue. I will focus on making the header a separate component. In order to make the header reusable I would like to use the concept of barrel export with the header component. If you kindly allow me to work on this issue @sainak @aparnacoronasafe @rithviknishad |
Hi, @sainak can I work on the issue, I would create a new general header component that would fit most of the types shown, for any extra case we can create a separate functional component in the same component file |
@sainak @aparnacoronasafe any updates on this issue?? |
Hii @sainak can i work on this issue. |
I would like to work on this , can you please assign me |
Please go ahead. However, the suggested design is missing some elements. like the "Live / Discharge" tabs. Please be mindful of retaining all the elements in the headers |
@saloni0419 @ab1123 @SinghYuvraj0506 @kumar11jr @UdaySagar-Git |
Hii @sainak can i work on this issue. |
hi @sainak can i work on this issue? -i will make a reusable component named Header in a Common/components/ directory named Header.js file and the final result may look like this |
Hii @sainak , I would like to work on this , can you please assign me |
@bishwas-10 this still does not look consistent at all across all pages. The objective is to have consistent placement of common elements like filter buttons should be present in the same location on every page. Same with Import/Export, Add (Patient | Asset | ...), etc. |
@rithviknishad ok i will work on that as i mentioned above will be changed according to your suggestion. |
|
@sainak @rithviknishad , i have built a mockup considering all the above conditions From the above images of headers we currently have, I found some points :-
The mockup solves all these problems,:
in technical aspect |
@SinghYuvraj0506 This looks great and example code seems to be very reusable and would lead to a consistent design pattern. Just letting you know that, we generally refrain from "Icon Only" designs. It'd be great if labels are also present along with the icons so any users who may not be able to interpret icons would also find it easy to use. |
@rithviknishad i would use labels instead of icons, or we could even use the tip to tell about the tool over hovering it. |
But we already have a hamburger menu for mobile. Did you mean to have two hamburger menus? |
Hi @sainak, I would like to work on this issue, please assign. |
@rithviknishad I noticed the issue about enhancing all the headers across the pages. I’d like to take up this task. In my recent PR #9392 , I worked on enhancing the header of the Asset page, which gave me a deeper understanding of the codebase and the header structure. For this task, I will:
I would like to work on this issue. |
@Jacobjeevan can I create an issue for enhancing the Shifting Page Header Layout to align it with the Facilities and Patient header layouts. Also, I will ensure to use shadcn UI components. |
No need to create a new issue; I can assign this one to you 👍 |
@Jacobjeevan sure, thank you |
@Jacobjeevan please check this.What we can add in resources count 🤔 Desktop ViewMobile View |
before you work on this, do checkout: things have changed quite a bit over there. |
Do I have to make changes according to these PRs' codebase? or wait to merge these |
i'd recommend hold this for now, and take this up if necessary after #9262 is merged. |
let me help |
@rithviknishad Okay , I will wait for the merge. However, I have gone through these PRs and set up the form-field-v1 branch locally. |
most of the pages are designed already, closing this issue |
Currently the header is very inconsistent and space consuming on the screen so, to fix that make the header a reusable component
current headers across pages
very rough sketch:
cc: @aparnacoronasafe
The text was updated successfully, but these errors were encountered: