Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple Same API Calls are been called in linked skills section #6652

Closed
nihal467 opened this issue Nov 16, 2023 · 0 comments · Fixed by #6596
Closed

Multiple Same API Calls are been called in linked skills section #6652

nihal467 opened this issue Nov 16, 2023 · 0 comments · Fixed by #6596

Comments

@nihal467
Copy link
Member

nihal467 commented Nov 16, 2023 •
edited
Loading

Describe the bug

When we click the linked skill button on a user card which already have a skill, inside the network tab, we can see same API is called multiple times

To Reproduce
Steps to reproduce the behavior:

  1. Go to linked facility button on user card with already skill linked
  2. See error

Expected behavior

Same API for same result shouldn't be called twice in linked skill

Screenshots

image
@github-project-automation github-project-automation bot moved this to Triage in Care Nov 16, 2023
@nihal467 nihal467 mentioned this issue Nov 16, 2023
Merged
@rithviknishad rithviknishad moved this from Triage to Up Next in Care Nov 17, 2023
@rithviknishad rithviknishad linked a pull request Nov 17, 2023 that will close this issue
Replaced useDispatch w. useQuery/request: Users (src/Components/Users/**) [5 out of 5 components] #6596
Merged
khavinshankar pushed a commit that referenced this issue Dec 6, 2023
@thedevildude @rithviknishad @nihal467
Replaced useDispatch w. useQuery/request: Users (src/Components/Users…
a6ed2bc 
…/**) [5 out of 5 components] (#6596)

* replaced getUserDetails and getUserListSkills actions with useQuery

* replaced partialUpdateUser action with request

* replaced updatePassword action with request

* replaced dispatch with useQuery in UserFilter.tsx

* Bug Fix: UserFilter tried fetching district when district_id was not available

* addUser and checkUsername action replaced with request

* replaced useDispatch with request in UserAdd component

* replaced useDispatch with useQuery and request in SkillsSlideOver

* replaced useDispatch with useQuery and request in ManageUsers

* solved issue #6652 | passed user skills as props to SkillSelect

* removed unnecessary console logs

* re-added showAll as dependency to skillSearch

* removed unnecessary console logs

* replaced fetchDistrict request with useQuery and removed isLoading

* fixed error notification in ManageUsers

* removed unnecessary useState from ManageUsers

* code fixes in SkillsSlideOver

* code fixes in UserAdd

* code fix in UserFilter

* code fix in UserProfile

* removed redundant code

* added proper types and fixed redundant code

* removed redundant fireRequest actions

* fix http 301 redirect due to missing trailing slash

* Update TRes of userListFacility in src/Redux/api.tsx

Co-authored-by: Rithvik Nishad <[email protected]>

* resolved imports

---------

Co-authored-by: Rithvik Nishad <[email protected]>
Co-authored-by: Rithvik Nishad <[email protected]>
Co-authored-by: Mohammed Nihal <[email protected]>
@github-project-automation github-project-automation bot moved this from Up Next to Done in Care Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Care
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replaced useDispatch w. useQuery/request: Users (src/Components/Users/**) [5 out of 5 components]
1 participant
@nihal467