-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coastal_ian_hsofs_schism #100
Comments
When I am using pyschism to produce the bctides.in by using the following code
It gave me the following error:
Do you have any suggestions for fix this error? Thank you very much! |
As afar as I remember this happens when there's a segment of the open boundary which is dry, so when trying to interpolate values from TPXO it encounters nans and masks them hence causing interpolation problem. My suggestion is to find those instances of open boundary nodes and make them land boundary. |
Hi @SorooshMani-NOAA , I have fixed the dry point problem and made the input files without any error messages, and when I try to run it on Hercules, SCHISM log gave me the following error message:
Do you have any experience with this error? Thank you very much! |
@yunfangsun did you manually modify the grid? Maybe you removed it from the ocean boundary but didn't add it to the land boundary? |
Thank you @SorooshMani-NOAA And @pvelissariou1 suggested that: try to remove ADCIRC mesh's levies manually. The levies using a different tag, such as look for ibtype 3,4,5 in the file, for example something like: 5 24 = Number of nodes for land boundary 2. and also check grid_subs.F90 for the mesh read. I have removed 7696 nodes, but SCHISM gives me a new error: And for ocsmesh auto_generate(-10), it gave the following, which seems can't generate correct boundaries: And now I will try to do it manually by SMS https://github.com/noaa-ocs-modeling/SurgeTeamCoordination/issues/390#issuecomment-2130285790 |
To me it still seems like an issue with manual boundary modification. I'm not familiar with SMS, but you can specify polygons in OCSMesh to setup boundary manually as well. First call the |
Thank you @SorooshMani-NOAA Firstly I compared the hsofs mesh with the levies removed as @pvelissariou1 suggested. The original hsofs boundaries are as follows: The difference between the twos is as follows: It is located at the mississippi river estuary. Then I use ocsmesh set_open and set_land to manually reset the boundaries as follows: With this gr3 file, SCHISM could smoothly run |
From @pvelissariou1 When compiling SCHISM standalone or coupled, in order to build the utilities as well (required) the following option/flag needs to be passed to cmake from the commandline: -DBUILD_TOOLS=ON. This will create the build_fv3_coastalS folder and compile SCHISM. The UFS executable will be something like: fv3_coastalS.exe To find all the utility executables in the build_fv3_coastalS run: I suggest creating a "bin" directory outside the build_fv3_coastalS and copy all executables to the "bin" directory. In ufs-coastal the actual model executable is not built (if needed we can add this capability in the future). The UFS executable (fv3_coastalS.exe) contains CDEPS, CMEPS and SCHISM and it can be run through UFS by calling only the SCHISM model. However, when I use the
is already used to build a source directory. It cannot be used to build
Specify a unique binary directory name. |
@yunfangsun Make sure when building SCHISM in ufs-coastal that you don't supply the BLD_STANDALONE option. I have compiled SCHISM with the command: The instructions will change slightly in a few days as I will fix the confict issues between BLD_STANDALONE and BUILD_TOOLS. |
Hi @SorooshMani-NOAA , I am using PySchism to generate the input files for SCHISM, the atmosphere forcing is ERA5, which is downloaded to sflux folder, and there is no My setting is as follows:
|
@yunfangsun in the script you shared I don't see where you get the ERA5 files. Are you downloading them separately? The ERA5 part is commented in your script. In an example I have somewhere I do this to write ERA5 files: era5 = ERA5()
era5.write(
outdir=schism_dir / "sflux",
start_date=start_date,
rnday=rnday.total_seconds() / timedelta(days=1).total_seconds(),
air=True, rad=True, prc=True,
bbox=atm_bbox,
overwrite=True) and this to write the rotation file: windrot = gridgr3.Windrot.default(hgrid)
windrot.write(schism_dir / "windrot_geo2proj.gr3", overwrite=True) Last time I used ERA5, it didn't support |
Thank you very much! It helps a lot |
Hi @pvelissariou1 , With the And I have already changed Thank you! |
@yunfangsun The combination |
Hi @pvelissariou1 , |
@yunfangsun Did you compile with the USE_ATMOS ON? I guess you are using the pschism* executable instead the fv3* executable |
I am using And using |
@yunfangsun As I mentioned before, try to use: |
I'm following along and may have missed a step, but could it be that @yunfangsun is using the default branch version, and @pvelissariou1 has added the BUILD_TOOLS option in cmmb branch? Meanwhile, the default (feature/coastal_app) branch is more recently sync'd with upstream, and has recent changes made by Ufuk on top of that. If I'm correct, this seems like a recipe for confusion... |
For the most recent cmmb branch, I have the following error when using
|
@janahaddad , @yunfangsun The changes I made are in the cmmb branch, which has the very latest SCHISM commit merged + my modifications. Need to use this branch for the time being. I believe, I have mentioned this before. SCHISM compiled standalone (outside ufs-coastal) and standalone (compiled inside ufs-coastal) should give exactly the same results. |
@yunfangsun , @janahaddad Let me reclone ufs-coastal and recompile schism on hercules to see if I get any errors. Stand by.... |
I think the cmmb branch is corrupted. Let me fix it ... |
@yunfangsun , @janahaddad , @saeed-moghimi-noaa I updated/fixed the ufs-coastal cmmb branch. SCHISM points to the schism repo cmmb branch. That branch is fully syncronized with the master branch and includes my updates as well. Clone ufs-coastal: NOTE: This is the latest version(commit) of SCHISM, please check the SCHISM/sample_inputs/param.nml for changes and recent updates. Soroosh has documented these (in his github issue) when I helped him to compile the latest version of SCHISM. |
I suggest working on commit hash instead of branch name ... so that everyone works on a given commit until you tell us to use a newer one later. Working based on dynamic branch names makes it much harder to track down issues. |
Hi @pvelissariou1 , Thank you! Now I can compile the cmmb branch of ufs-coastal, and I have updated the param.nml (many changes from the previous version) Although I have turned off the vegetation model by setting
I will look into the name list to see if extra modifications are needed. |
@feiye-vims @josephzhang8 |
Ah.. he's using the new version. Just add nbins_veg_vert=1 in CORE/ section of param.nml. |
Thank you, I have just changed it to
And in the param.nml, line 732, position 25, the setting is using the default values:
Could you please advise how to modify this part? Thank you! |
I didn't know you added this part also. Change nbins_veg_vert=2 |
@yunfangsun You need to specify both as Joseph mentioned. It is already documented in the github issues related to SCHISM. @josephzhang8 I have submitted a PR on how to build SCHISM in and outside ufs-coastal. Waiting your approval. |
Thx @pvelissariou1 for the reminder. I'm just out of meetings and will look at PR now... thx |
@josephzhang8 Thank you very much Joseph. |
Thank you @pvelissariou1 @josephzhang8 @pvelissariou1 I see schism-dev/pyschism#126 Now I have a new error message:
Could I know where I can turn off the usage of tvd.prop
|
You set ibc=0 (baroclinic model) so it requires tvd.prop. |
Thank you @josephzhang8 , Hi @pvelissariou1 , with the compilation of |
The problem is solved by changing nws=2 |
thanks for resyncing with the feature/coastal-app first @pvelissariou1 . Seems like that's a best practice to use moving forward for any "non-default" branch such as the cmmb branch. That's one thing for us to discuss this afternoon |
@pvelissariou1 Please add the hash of the cmmb branch that working here. Thanks |
Here is the hash: 38d9501fda5ac5849055e29978f6b4326b26c5f1 (38d9501) schism/master |
Please add a git command line on how to clone it (which repo and so on). Thanks |
Working schism version/commit (standalone/ufs-coastal) as of 06/07/2024 How to get/clone this commit locally Approach 1: Download the zip archive Approach 2: Clone the repo and checkout the specific commit into a branch
Approach 3: Clone the repo and checkout the specific commit
|
@yunfangsun , @Armaghan-NOAA , @janahaddad , @saeed-moghimi-noaa I have updated the ufs-coastal (cmmb branch) so the SCHISM submodule pointer points to SCHISM (master) - commit: 38d9501. |
Thanks Takis, Highly appreciated. |
The case is now finished in /work2/noaa/nos-surge/yunfangs/hurricane_ian/ufs_sch_hsofs |
@mansurjisan see here |
No description provided.
The text was updated successfully, but these errors were encountered: