Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WARNING:root:WARNING: Unable to get integer from "" #657

Open
JamesParrott opened this issue Oct 8, 2024 · 1 comment
Open

WARNING:root:WARNING: Unable to get integer from "" #657

JamesParrott opened this issue Oct 8, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@JamesParrott
Copy link

JamesParrott commented Oct 8, 2024

🔬 How To Reproduce

Steps to reproduce the behavior:

>pipx install github-dependents-info
>github-dependents-info --repo nvuillam/npm-groovy-lint

produces:

WARNING:root:WARNING: Unable to get integer from ""
WARNING:root:WARNING: Unable to get integer from ""
Total: 24
Public: 24 (1625 stars)
Private: -24

Environment

Windows 11, pipx 1.2.0, CPython 3.11.4

📈 Expected behavior

No warnings during normal operation, as described in the readme.

@JamesParrott JamesParrott added the bug Something isn't working label Oct 8, 2024
@JamesParrott
Copy link
Author

JamesParrott commented Oct 8, 2024

It happens without pipx too, in a normal venv.

It is due to an intentional warning, which I personally find to be irritating and pointless. If Github's API returns an empty string instead of "0", then in my opinion empty strings and everything other value the API is likely to return, should be handled gracefully by applications built on that API.

Please change this warning to a debug message:.

logging.warning(f'WARNING: Unable to get integer from "{number_as_string}"')

There is no value in showing it to all users during typical execution, and it detracts from the UX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant