Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The bug about compute feature index #56

Open
usergxx opened this issue Aug 13, 2024 · 0 comments
Open

The bug about compute feature index #56

usergxx opened this issue Aug 13, 2024 · 0 comments

Comments

@usergxx
Copy link

usergxx commented Aug 13, 2024

In the voxel_pooling function, the computation of geom_feats indices involves dividing the positions by dx and then performing rounding to compute the indices.

geom_feats = ((geom_feats - (self.bx - self.dx/2.)) / self.dx).long()

Directly using floor rounding can lead to errors, such as -0.9 rounding to 0, which may incorrectly satisfy the selection criteria and increase the number of invalid features. The intended height range should be [-10m, 10m), but with the current approach, the range becomes (-30m, 10m).

kept = (geom_feats[:, 0] >= 0) & (geom_feats[:, 0] < self.nx[0])\ & (geom_feats[:, 1] >= 0) & (geom_feats[:, 1] < self.nx[1])\ & (geom_feats[:, 2] >= 0) & (geom_feats[:, 2] < self.nx[2])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant