Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pipelines and pipeline elements #37

Open
kubouch opened this issue Dec 28, 2024 · 2 comments
Open

Add pipelines and pipeline elements #37

kubouch opened this issue Dec 28, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@kubouch
Copy link
Collaborator

kubouch commented Dec 28, 2024

Currently, pipelines and pipeline elements are missing. In Nushell the hierarchy is

block -> pipeline -> pipeline element -> expression

while we have only

block -> AST node
@kubouch kubouch added the enhancement New feature or request label Dec 28, 2024
@sholderbach
Copy link
Member

Is this full hierarchy useful in IR land? I guess it might make sense to have a statement/expression level, but for transformations we may want to do are the pipeline/pipeline elemen hierarchies still as useful. (e.g. if we want to lift a | get bla to a direct cell path access etc.

@kubouch
Copy link
Collaborator Author

kubouch commented Jan 8, 2025

Lifting | get bla to a direct cell path access would require get to be a parser keyword (or done later via some IR optimization?). I haven't looked closely to the IR yet, so I can't tell if it would be better with or without pipelines, but we'll need some way to track command inputs/outputs. We'll also need it at the AST level to parse and typecheck it properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants