Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused package justinrainbow/json-schema #688

Open
DannyvdSluijs opened this issue Jul 15, 2024 · 1 comment
Open

Unused package justinrainbow/json-schema #688

DannyvdSluijs opened this issue Jul 15, 2024 · 1 comment

Comments

@DannyvdSluijs
Copy link
Contributor

Q A
Bug report? no
Feature request? no
Library version master

As a maintainer of json-schema I was looking at our top dependent libraries in order to do some smoke testing for the upcoming v6 release. I was surprised to see there was no code related to json-schema in this repo although it being on of the top dependants (No.3 if you count by number of ⭐ ).

Timeline

🔍 After some puzzling I found the following timeline and reason why we are still left with json-schema as a dependency.

  • 2019-06-08: PR#169 adds composer/composer as a dependency, this is the first time justinrainbow/json-schema is installed (verified with composer why justinrainbow/json-schema on 5d0e1af
  • 2020-01-30: PR#342 adds justinrainbow/json-schema in order to pin the required version to avoid conflicts.
  • 2022-04-29: PR#575 removes composer/composer as a dependency
  • 2024-07-15: f476219 justinrainbow/json-schema is still a first class dependency

Current output on my fork of master

$ composer why justinrainbow/json-schema
nunomaduro/phpinsights dev-master requires justinrainbow/json-schema (^5.2.13)

$ git rev-parse --short HEAD 
f476219

Why no PR?

At this time I don't have the time to draft a PR but rather took the time to create a decent report making this for a "Good first issue"

@Jibbarth
Copy link
Collaborator

Thanks, I will handle it 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants