Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

units of section_atomic_multipoles.atomic_multipole_values #14

Open
ondracka opened this issue Apr 30, 2021 · 1 comment
Open

units of section_atomic_multipoles.atomic_multipole_values #14

ondracka opened this issue Apr 30, 2021 · 1 comment

Comments

@ondracka
Copy link

I'm trying to save mulliken charges into this section in the lobster parser. This should be the correct place for it (atomic_multipole_kind has allowed value 'mulliken'), but I can't set proper charge units for atomic_multipole_values as it is unitless currently.

@JosePizarro3
Copy link
Contributor

I'd say the solution that we typically do is to define units separately to the value of something, in case the units are a bit code- or case-dependent.

But in any case, I think this issue gets a bit outdated with the new schema. I'd say it is very easy to define a property under AtomsState for the charge / spin multipoles. We didn't do it yet thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants