You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think some configuration of the tests is wrong. The test should be testing the parse() function of the class itself, without the need to import nomad.client import parse function. I think this client function works matching the parser, or is it implemented such that any parser plugin will be recognized? Also, how optimized this matching would be w.r.t to simply test the class parse() function?
Furthermore, doing this nomad.client.parse creates the need of pointing to the abs path of the tests/data folder, instead of using the relative path. In other words, right now the test config is:
I think some configuration of the tests is wrong. The test should be testing the
parse()
function of the class itself, without the need to importnomad.client import parse
function. I think this client function works matching the parser, or is it implemented such that any parser plugin will be recognized? Also, how optimized this matching would be w.r.t to simply test the classparse()
function?Furthermore, doing this
nomad.client.parse
creates the need of pointing to the abs path of thetests/data
folder, instead of using the relative path. In other words, right now the test config is:but it should be:
The text was updated successfully, but these errors were encountered: