Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure of SpectroscopyProperties #6

Open
JosePizarro3 opened this issue Jun 5, 2023 · 3 comments
Open

Restructure of SpectroscopyProperties #6

JosePizarro3 opened this issue Jun 5, 2023 · 3 comments

Comments

@JosePizarro3
Copy link
Contributor

@markus1978 I saw that this parser contains some population of results. As I am currently working on Spectra from computations (https://gitlab.mpcdf.mpg.de/nomad-lab/nomad-FAIR/-/merge_requests/1316), can I move the normalization here to the proper ResultsNormalizer, hence merging some Area B and Area C stuff?

I plan on working on the Spectroscopy properties visualizers, so it is able to allocate different provenances and show this properly.

If you are ok then, I think the 1008 should be merge into master, and the ref in gitlab be updated. I can handle updating the reference at the same time I do the changes.

@markus1978
Copy link
Member

There are currently no rules for the normalization. If you think it makes sense to centralize in the result normalizer, you can go ahead. But there will be some restructuring of the normalzation in the near future.

@JosePizarro3
Copy link
Contributor Author

Ok, as this is a minor thing I guess it will not be a problem.

What about merging 1008 into master?

@JosePizarro3
Copy link
Contributor Author

JosePizarro3 commented Jun 5, 2023

Well, now that I think maybe it makes sense to move it to the repo database, merging them together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants