Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu 22.04 is a Tier 1 platform, but main does not build with default gcc, and we do not provide instructions #56475

Open
mcollina opened this issue Jan 5, 2025 · 4 comments
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors.

Comments

@mcollina
Copy link
Member

mcollina commented Jan 5, 2025

Cloning the repo and running:

$ ./configure
Node.js configure: Found Python 3.10.12...
WARNING: C++ compiler (CXX=g++, 11.4.0) too old, need g++ 12.2.0 or clang++ 8.0.0
WARNING: warnings were emitted in the configure phase
INFO: configure completed successfully

However, this happens on Ubuntu 22.04.5 LTS, which is a Tier 1 platform. I have not found any instructions in https://github.com/nodejs/node/blob/main/BUILDING.md#unix-prerequisites:

sudo apt-get install python3 g++ make python3-pip

Which installs gcc 11.4.0.

@targos
Copy link
Member

targos commented Jan 5, 2025

We can't give general instructions for every possible Linux distribution or version of it.

@targos
Copy link
Member

targos commented Jan 5, 2025

In other words, I think it's fair to assume that the documentation is for the latest version (Ubuntu 24.04 in this case)

@joyeecheung
Copy link
Member

joyeecheung commented Jan 9, 2025

It seems interesting to update the configuration script to give some tips on how to update your compiler accordingly on the platform where it is run, instead of saying generic things like need g++ 12.2.0 or clang++ 8.0.0. I have no idea how complex this is, though. If that sounds like a good idea, we can label it as a good first issue and see if someone's happy to take it on.

@mcollina
Copy link
Member Author

mcollina commented Jan 9, 2025

This is solved with:

sudo apt-get install gcc-12
export CXX=g++-12
./configure

Should be easy to add to the doc, at least for ubuntu.

@mcollina mcollina added good first issue Issues that are suitable for first-time contributors. doc Issues and PRs related to the documentations. labels Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors.
Projects
None yet
Development

No branches or pull requests

3 participants