Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c14h, yarpnarp: sql.go refactoring #7

Open
Merovius opened this issue Jun 5, 2016 · 0 comments
Open

c14h, yarpnarp: sql.go refactoring #7

Merovius opened this issue Jun 5, 2016 · 0 comments

Comments

@Merovius
Copy link
Contributor

Merovius commented Jun 5, 2016

sql.go sollte refactored werden, um http://github.com/jmoiron/sqlx zu verwenden. Ich würde vmtl. zwei Schritte vorschlagen:

  • Refactoring, dass sql.NullString, sql.NullBool usw. benutzt wird
  • Refactoring, dass sqlx.Get/sqlx und so benutzt

Wir sollten auch das sql-CRUD in ein eigenes Paket auslagern, welches dann von allen commands gemeinsam genutzt werden kann.

Merovius added a commit that referenced this issue Jul 30, 2016
The data package should improve code-reuse by bundling together the SQL
operations into a common package. It will be marginally less efficient
than using SQL directly, but it will enforce best practices, remove
duplication and prevent mistakes from broken queries. #7 is the
associated issue.

To begin with, this updates termine to use the new package. It also
refactors termine a bit.

Fixes #3
cherti pushed a commit that referenced this issue Jul 30, 2016
* Add a package to abstract SQL operations

The data package should improve code-reuse by bundling together the SQL
operations into a common package. It will be marginally less efficient
than using SQL directly, but it will enforce best practices, remove
duplication and prevent mistakes from broken queries. #7 is the
associated issue.

To begin with, this updates termine to use the new package. It also
refactors termine a bit.

Fixes #3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant