Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Card nested anchors #1008

Open
Rozerinay opened this issue Dec 13, 2024 · 2 comments · May be fixed by #1099
Open

BUG: Card nested anchors #1008

Rozerinay opened this issue Dec 13, 2024 · 2 comments · May be fixed by #1099
Assignees
@GerwinTerpstra

Comments

@Rozerinay
Copy link
Contributor

Warning: validateDOMNesting(...): <a> cannot appear as a descendant of <a>

Zowel de Card zelf als de Link (van Utrecht) component is een anchor. In Card zit nu zo'n Link wat resulteert in nested anchors.

https://rijkshuisstijl-community-git-fix-errors-nl-design-system.vercel.app/?path=/docs/rhc-card--docs
@Rozerinay Rozerinay converted this from a draft issue Dec 13, 2024
@JoeriRoijenga
Copy link
Contributor

JoeriRoijenga commented Dec 18, 2024 •
edited
Loading

@Rozerinay gaat hier even naar kijken wat hiervoor handig is qua design. Welke van de twee linkjes: https://rijkshuisstijl-community.vercel.app/?path=/docs/rhc-card--docs kan hier weg?

Dit is misschien ook wel handig om te combineren met: #1008

@JoeriRoijenga JoeriRoijenga mentioned this issue Dec 18, 2024
Open
@GerwinTerpstra GerwinTerpstra self-assigned this Dec 30, 2024
@GerwinTerpstra GerwinTerpstra linked a pull request Jan 10, 2025 that will close this issue
FIx: card itself is no longer an anchor #1099
Open
@GerwinTerpstra
Copy link
Contributor

#1099

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GerwinTerpstra GerwinTerpstra

Labels
None yet
Projects
Community Sprint - Rijkshuisstijl componenten
Status: Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FIx: card itself is no longer an anchor nl-design-system/rijkshuisstijl-community
3 participants
@JoeriRoijenga @Rozerinay @GerwinTerpstra