Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: @utrecht/component-library-css vervangen met @utrecht/components #1009

Open
Rozerinay opened this issue Dec 13, 2024 · 1 comment
Open

Refactor: @utrecht/component-library-css vervangen met @utrecht/components #1009

Rozerinay opened this issue Dec 13, 2024 · 1 comment

Comments

@Rozerinay
Copy link
Contributor

Rozerinay commented Dec 13, 2024 •
edited by JoeriRoijenga
Loading

Context
Nu gebruiken wij @utrecht/component-library-css overal en dit is ook aanwezig in @utrecht/components. In @utrecht/components zitten ook de README files, voor het aanpassen van componenten is dit ook handig om te hebben.

Oplossingsrichting
Gebruik alleen het @utrecht/components package zodat we minder externe packages nodig hebben en toegang hebben tot README files.
@Rozerinay Rozerinay converted this from a draft issue Dec 13, 2024
@JoeriRoijenga JoeriRoijenga mentioned this issue Dec 18, 2024
Closed
@Rerbun Rerbun moved this from Todo to In Progress in Community Sprint - Rijkshuisstijl componenten Dec 30, 2024
@Rerbun Rerbun self-assigned this Dec 30, 2024
@Rerbun Rerbun mentioned this issue Jan 3, 2025
Merged
Rerbun added a commit that referenced this issue Jan 3, 2025
@Rerbun
feat: major update to how documentation is fetched and rendered and m…
45148db 
…ade small fixes to make everything as consistent as possible (#1070)

closes #981 
closes #1010 
also made first steps to use @utrecht/components, but only in storybook
for now (#1009)

- There are a lot of // TODO comments because in a lot of cases the
documentation is not structurized correctly in @utrecht/components.
Wherever it was in the right structure I used the Utrecht documentation
as much as possible (although sometimes they were very lacking in
content, in which cases I skipped them as well)
- I added functionality to packages/storybook/config/preview.tsx to
render links and componentOrigin text that can be added using the
github, figma, nldesignsystem and componentOrigin parameters in
storybook respectively.
- Here is an example of a storybook page where the links are filled with
parameters and the documentation is coming from @utrecht/components:
[Radio
button](https://rijkshuisstijl-community-git-chore-utre-1cc52e-nl-design-system.vercel.app/?path=/docs/rhc-radio--docs)

---------

Co-authored-by: Ruben Smit <[email protected]>
@Rerbun Rerbun mentioned this issue Jan 7, 2025
Closed
@Rerbun Rerbun moved this from In Progress to Review in Community Sprint - Rijkshuisstijl componenten Jan 7, 2025
@JoeriRoijenga
Copy link
Contributor

Dit werkt nog niet. Build straat faalt omdat (waarschijnlijk) Utrecht niet alle dependencies goed heeft staan. Hier staan alle devDependencies, daar lijkt sowieso alert-css te ontbreken, mogelijk nog wel meer.

Image

In het screenshot hierboven is te zien dat er ook verwijzingen zijn naar het gebruik van de monorepo (code):

"devDependencies": {
  "@utrecht/alert-css": "workspace:*",
  "@utrecht/backdrop-css": "workspace:*",
  "rollup": "4.18.0"
},

Het lijkt mij dat dit niet de bedoeling is?

@Rerbun Rerbun removed their assignment Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Community Sprint - Rijkshuisstijl componenten
Status: On hold
Milestone
No milestone
3 participants
@Rerbun @JoeriRoijenga @Rozerinay