An overview of how we will manage old or out-of-date pull requests.
We will close any pull requests older than two weeks.
Exceptions can be made for PRs that have active review comments, or that are awaiting other dependent PRs. Closed pull requests are easy to recreate, and little work is lost by closing a pull request that subsequently needs to be reopened.
We want to limit the total number of PRs in flight to:
- Maintain a clean project
- Remove old PRs that would be difficult to rebase as the underlying code has changed over time
- Encourage code velocity
Between the first RC build (~6/22) and v1.0, we will adopt a higher bar for PR merges. For v1.0 to be a stable release, we need to ensure that any fixes going in are very well tested and have a low risk of breaking anything. Refactors and complex changes will be rejected in favor of more strategic and smaller workarounds.
These PRs require:
- A risk assessment by the code author in the PR. This should outline which parts of the code are being touched, the risk of regression, and complexity of the code.
- Two LGTMs from experienced reviewers.
Once those requirements are met, they will be labeled ok-to-merge and can be merged.
These restrictions will be relaxed after v1.0 is released.