Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceWorkers in Hub and Keyguard are blocking each other #335

Open
Bettelstab opened this issue May 13, 2019 · 4 comments
Open

ServiceWorkers in Hub and Keyguard are blocking each other #335

Bettelstab opened this issue May 13, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@Bettelstab
Copy link
Contributor

Bettelstab commented May 13, 2019

Image from iOS

@sisou
Copy link
Member

sisou commented May 13, 2019

I was able to create an account and go past this screen on the testing iPhone without problem.

@sisou sisou added the needs reproduction A stable method reproduction is required label May 16, 2019
@sisou
Copy link
Member

sisou commented May 19, 2019

And now I experience it, too... :(

@sisou sisou added bug Something isn't working and removed needs reproduction A stable method reproduction is required labels May 19, 2019
@sisou sisou changed the title Account creation gets stuck on iOS ServiceWorkers in Hub and Keyguard are blocking each other May 22, 2019
@sisou
Copy link
Member

sisou commented May 22, 2019

The issue has been traced back to the service workers on the Hub and Keyguard origins, which when both active, for some unknown reason block each other on iOS Safari. Safari on Desktop does not show this issue, although the service workers are also enabled there.

This looks like an iOS bug, which cannot be further tracked down.

For now we have heavy-heartedly disabled the service worker in the Keyguard, as that cookie contains less critical information (only the keyId, and the type of key), whereas the Hub cookie contains all active addresses and labels as well.

@Bettelstab
Copy link
Contributor Author

(+ only in redirect case)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants