Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MinimizeToTray++ addon to Linux build #276

Closed
darealshinji opened this issue Mar 5, 2014 · 8 comments
Closed

Add MinimizeToTray++ addon to Linux build #276

darealshinji opened this issue Mar 5, 2014 · 8 comments

Comments

@darealshinji
Copy link
Contributor

I know this addon is available on the Nightingale homepage, but that's not the newest version and you have to modify it so it works with 1.12.2a or newer builds. I think this is a feature that should be available by default and since all the icon-related issues are fixed, the tray icon should now definitely be visible.
The current source code: svn co http://svn.codefisher.org/svn/minimizetotray/

@rsjtdrjgfuzkfg
Copy link
Member

In general this issue tracker may be the wrong place, as we track core issues here. If we should adopt the add-on as a project, we could discuss that over at https://github.com/nightingale-media-player/nightingale-addons/issues. Thus, I'm for closing here.

I oppose any add-on bundling (except if we integrate it and hide it from the add-ons menu), but we may consider it in the recommended add-on list on firstrun imho.
Maybe a windows build would be nice as well...

@freaktechnik
Copy link
Member

I don't think a minimize to tray extension should even be recommended as it breaks the whole purpose of a windoe manager.

@darealshinji
Copy link
Contributor Author

Sorry, I've overseen nightingale-media-player/nightingale-addons. I'll talk there about this addon then instead of here.
@freaktechnik: I don't understand how a minimize to tray extension breaks the purpose of a window manager, as there are other programs with tray icon support such as VLC.

@freaktechnik
Copy link
Member

The existence of other programs doing that is not a reason as to why this doesn't break the idea of a window manager. Basically the window manager is in charge to let you choose which windows you want to see and have hidden. He also offers the GUI for that. If that sucks, it's not the program's fault. Minimizing to tray is forced by the program and hides it from the normal GUI and instead places it in a place it was never meant to be by the WM. You could now argue the idea that a music player is a service. But then nightingale was built the wrong way.

@freaktechnik
Copy link
Member

@rsjtdrjgfuzkfg
Copy link
Member

@freaktechnik with that explaination I agree that recommending it is probably a bad idea, at least on linux. On windows (and mac?) one might argue that users are forced into a window manager, thus applications need to fix OS issues :P

@darealshinji
Copy link
Contributor Author

It might be a stupid question, but which Unix window manager or desktop environment allows one to alternatively minimize programs to tray without installing additional software?

@freaktechnik
Copy link
Member

@darealshinji None that I know of. Most treat indicators as an indicator for the status of a service, thus they have no window associated with them.
@rsjtdrjgfuzkfg well, you aren't bound to Explorer on Windows either. You just have to modify your explorer.exe a bit. Which you probably want to do on your own, as you shouldn't trust tools from the internet to do what they claim. So yeah, it's a bit easier on linux.

EDIT: oh, and if I may counter myself: tabs do the same as minimize to tray extensions. And we have tabs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants