Silent crash on startup with old versions of Valet

[rosswintle]

Hi there - love PHP Mon. Thank you for making it.

This is all my fault for not running composer global update often enough, but I thought it was worth reporting as I did get stuck.

I was trying out v5 beta 2, and when the app was starting up it would appear in the menu bar for a few seconds and then disappear without any errors.

Updating from Valet 2.13.19 to latest (2.18.7) fixed the issue. But I wonder if it's worth reporting whatever the error was with the old version of Valet and recommending an upgrade?

Thanks

Ross

[nicoverbruggen]

Hi @rosswintle!

Hmm, I would want to know what crashed, because usually PHP Monitor will actually tell you if your Valet is out of date (lower than the expected minimum requirement). There's a chance that running valet --version failed because of this.

Could you attach your logs here? To find the logs, take a look in ~/Library/Logs/DiagnosticReports (in Finder) and see if there's any (log) files that start with "PHP Monitor". That will allow me to investigate what specifically went wrong.

Thanks!

[rosswintle]

Yep, logs are attached.

I guess the key bit is:

PHP_Monitor/Valet.swift:36: Fatal error: 'try!' expression unexpectedly raised an error: Swift.DecodingError.keyNotFound(CodingKeys(stringValue: "loopback", intValue: nil), Swift.DecodingError.Context(codingPath: [], debugDescription: "No value associated with key CodingKeys(stringValue: \"loopback\", intValue: nil) (\"loopback\").", underlyingError: nil))

PHP Monitor Logs.zip

Thanks

[nicoverbruggen]

Thank you! Yes, so apparently your Valet configuration file, config.json (with the old version) was lacking the "loopback" key, which I presumed had always been there.

Thank you for reporting this. I'll do two things in response to this:

1. I'll make the loopback key optional, which should resolve the crash
2. I might add another startup check which checks the integrity of the config.json file, just in case

Cheers!

[rosswintle]

Nice. Glad that was helpful. What even does the loopback key do? I've never heard of it. Will have to go look that up!

Thanks again.

[rosswintle]

Actually, thinking about it, I've probably never touched that file, so I wouldn't know. 😆