-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pinned software to latest #145
base: master
Are you sure you want to change the base?
Conversation
We were using v7.475 (~2.5y old) which had serious bug occasionally requesting excessive memory See https://mafft.cbrc.jp/alignment/software/changelog.html
41db559
to
f1e51c6
Compare
f1e51c6
to
23c3c72
Compare
Is there something motivating these updates at this time beyond "because they're possible"? If not, we should talk more broadly about why/when to make updates like this. Updates for their own sake are not always productive and often counter-productive. |
@tsibley very happy to talk more broadly about pros/cons of updates and how we'd want to do them, on which schedule etc I noticed that many pinned tools were quite out of date, so I thought I'll go ahead and see what the most up to date versions are to start a discussion, partially motivated by our recent snakemake update experience. More regular updates could help us reduce the changes necessary for updates if they become necessary as we'll notice any required changes earlier (once we know we need to change something, new code that is up to date won't need to be changed later) [most code that had to be changed for snakemake upgrade was actually written well after we could have been aware that the code we were writing wouldn't be v7 compatible] We definitely don't need to update every month, but bringing things up to date every half year or year could be good. Also, this PR is a good motivation to improve how we test images for compatibility, see #147 (thanks for your work there in #148!) So, absolutely no rush here, but something that'd be good to tackle. |
I think updates are good when there is a specific bugfix or improvement in a newer version that benefits users. Otherwise, they're neutral at best, or even detrimental given potential to introduce newer bugs/incompatibilities just by nature of change. For this PR, I'd approve 96ac3e8 as-is and 3a48047 with added detail that it fixes #42. |
Update arm jaxlib to v0.4.6Undone, see Mismatch between pip and conda dependency pins: which is the intended one? blab/evofr#24