Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloading an image inside an article does nothing on Android 13 #1302

Open
cemrich opened this issue Oct 25, 2023 · 2 comments
Open

Downloading an image inside an article does nothing on Android 13 #1302

cemrich opened this issue Oct 25, 2023 · 2 comments

Comments

@cemrich
Copy link
Contributor

cemrich commented Oct 25, 2023

Steps to reproduce

  1. Open an article with an image on Android 13
  2. Long click on the image
  3. Click the download button

Expected

App should ask for permission and download the image.

Actual

Nothing happens. Asking for permission error gets printed in logcat.

Cause

The documentation states regarding WRITE_EXTERNAL_STORAGE:

Note: If your app targets Build.VERSION_CODES.R or higher, this permission has no effect.

@cemrich
Copy link
Contributor Author

cemrich commented Oct 25, 2023

I don't know if downloading single images is a feature worth maintaining. It requires maintaining a lot of code and handling storage access is notorously difficult on Android. I would suggest dropping this feature and replace it with a standard Android share dialog.

@David-Development
Copy link
Member

With the sharing option my only concern is that we sometimes have a local file (if it's cached by the image cache) and sometimes we have a web url (in case it's not cached yet). So we'd have to handle both cases.

I didn't get a chance to test yet but we also need to check the "Download all images" option. Maybe it's broken too.. not 100% sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants