Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Container queries - storybook changes #806

Open
jps opened this issue Apr 5, 2023 · 2 comments
Open

Container queries - storybook changes #806

jps opened this issue Apr 5, 2023 · 2 comments
Assignees
@LukeFinch
Labels
story a user facing change
Milestone
Component Enhance...

Comments

@jps
Copy link
Contributor

jps commented Apr 5, 2023 •
edited by n-dorman
Loading

Description

Looks like we should be able to proceed with this now as emotion-js/emotion#2876 has been closed

Spike outcome from before: https://nidigitalsolutions.jira.com/wiki/spaces/NPP/pages/4135977048/PPDSC-2238+CSS+Container+Queries

Previous PR: #400

Docs will be updated in separate ticket

Follow the suggestion from the PR and add storybook scenario for

  • GridLayout ( handleResponsiveProp function )
  • CardComposable
  • Block
  • TextBlock
  • Hidden and Visible

Add support for new units as per the PR

How do we want to document this

Business Benefit/Value

Allow consumers to use this new capability with NewsKit

Acceptance Criteria

As a user of the design system, I should be able to use container queries
@jps jps added triage This issue will be reviewed by the team story a user facing change labels Apr 5, 2023
@jps jps added this to the Component Enhancements milestone Apr 5, 2023
@jps jps moved this to Analysis in NewsKit Apr 5, 2023
@jps jps removed the triage This issue will be reviewed by the team label Apr 5, 2023
@jps jps moved this from Analysis to Ready for estimation in NewsKit Apr 17, 2023
@n-dorman n-dorman reopened this Apr 20, 2023
@jps
Copy link
Contributor Author

jps commented Apr 20, 2023 •
edited
Loading

@jps create docs ticket and add

Update docs

Estimated at: 3 story points

@jps jps moved this from Ready for estimation to Estimated (not prioritised) in NewsKit Apr 20, 2023
@jps jps mentioned this issue Apr 20, 2023
Open
@JohnTParsons JohnTParsons moved this from Estimated (not prioritised) to Ready to do in NewsKit Apr 21, 2023
@JohnTParsons JohnTParsons changed the title Container queries Container queries code changes Apr 21, 2023
@JohnTParsons JohnTParsons changed the title Container queries code changes Container queries storybook changes Apr 21, 2023
@JohnTParsons JohnTParsons mentioned this issue Apr 21, 2023
Open
@JohnTParsons
Copy link
Collaborator

JohnTParsons commented Apr 21, 2023 •
edited
Loading

Docs ticket created by James is: #840

@JohnTParsons JohnTParsons changed the title Container queries storybook changes Container queries - storybook changes Apr 21, 2023
@LukeFinch LukeFinch moved this from Ready to do to In progress in NewsKit Apr 25, 2023
@LukeFinch LukeFinch self-assigned this Apr 25, 2023
@LukeFinch LukeFinch linked a pull request Apr 27, 2023 that will close this issue
feat(806): container queries #858
Closed
8 tasks
This was referenced May 5, 2023
Closed
Closed
@LukeFinch LukeFinch moved this from In progress to Design review in NewsKit May 5, 2023
@LukeFinch LukeFinch moved this from Design review to Peer review in NewsKit May 5, 2023
@LukeFinch LukeFinch moved this from Peer review to Design review in NewsKit May 9, 2023
@LukeFinch LukeFinch moved this from Design review to Peer review in NewsKit May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LukeFinch LukeFinch

Labels
story a user facing change
Projects
NewsKit
Status: Peer review
Milestone
Component Enhancements
4 participants
@jps @JohnTParsons @LukeFinch @n-dorman