Merge dev branch into master - post refactor

[jarmoza]

Now that we are complete with the store refactor, subsequent features and testing, I will no merge the development branch dev_components_talk_to_store_directly into the master branch of the annotation tool.

[surchs]

👍 Only comment: this may be a good candidate for pair programming - if there are any merge conflicts to be resolved, that is (but I strongly expect there will be).

[jarmoza]

See #436 WIP PR. So far so good actually with merges with the exception of something quirky happening on GitHub's side re: e2e testing.

Re-running now here: https://github.com/neurobagel/annotation_tool/actions/runs/5137827457

If can't resolve will reach out to channel tomorrow for 2 sets of eyes.

[surchs]

hhm. e2e error could be many things. seems like the dev build fails which would make e2e fail as well. what are the merge conflicts? I guess you only see those once you take the PR out of draft mode?

[surchs]

this seems clear enough to work on to me (and I think it is already worked on, no?). Either way: let's move to specify-done (or clarify the remaining things) and then get it worked on

[surchs]

Additional note on #437 (that is failing atm): I'm pretty sure the failure is because we introduced

annotation_tool/nuxt.config.js

Line 64 in 7ca5712

target: "static"

in 095261b.

I made a little test to remove the "static" build target in #438 and indeed the e2e passes (sidenote: still haven't figured out how to run GH actions easily on a branch so I don't have to make a PR, I guess manual would work?).

Unfortunately just removing "static" isn't the solution either, because we need that to deploy on GH pages. I could imagine that a fix would be to temporarily override the build target (i.e. make it "not static") in the GH actions workflow for the e2e test. Or the alternative is probably to figure out how to run the e2e tests with cypress against a statically compiled version of the app - I strongly believe that the latter is going to be harder.

[jarmoza]

@surchs Yes, temp paused work on this yesterday with @rmanaem having power out. I have resumed work on this today.