Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnosis annotations wiped when saved twice #339

Closed
jarmoza opened this issue Feb 2, 2023 · 4 comments
Closed

Diagnosis annotations wiped when saved twice #339

jarmoza opened this issue Feb 2, 2023 · 4 comments
Labels
annotation page download page usability Issue affecting user or developer experience.

Comments

@jarmoza
Copy link
Contributor

jarmoza commented Feb 2, 2023

As noted in #335, when saving Diagnosis annotations twice (via the 'Save Annotation' button on the Annotation page), Diagnosis columns in the table on the Download page appear completely clear of data.

image

This is similar to our previous bug #176 for categorical annotations (e.g. Sex)

@jarmoza jarmoza added download page annotation page bug:functional usability Issue affecting user or developer experience. labels Feb 2, 2023
@github-project-automation github-project-automation bot moved this to Inbox in Neurobagel Feb 2, 2023
@jarmoza jarmoza mentioned this issue Feb 2, 2023
@github-actions
Copy link

github-actions bot commented Mar 5, 2023

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 30 days.
We have applied the stale-issue label to indicate that this issue should be reviewed again and then either prioritized or closed.

@github-actions github-actions bot added the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Mar 5, 2023
@jarmoza jarmoza removed the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Mar 6, 2023
@surchs surchs removed the status in Neurobagel Mar 21, 2023
@surchs surchs moved this to Backlog in Neurobagel Mar 31, 2023
@rmanaem rmanaem moved this from Backlog to Specify - Active in Neurobagel Apr 5, 2023
@rmanaem rmanaem moved this from Specify - Active to Specify - Done in Neurobagel Apr 5, 2023
@rmanaem rmanaem moved this from Specify - Done to Implement - Active in Neurobagel Apr 5, 2023
@rmanaem rmanaem self-assigned this Apr 5, 2023
@rmanaem rmanaem moved this from Implement - Active to Specify - Active in Neurobagel Apr 5, 2023
@rmanaem rmanaem moved this from Specify - Active to Backlog in Neurobagel Apr 5, 2023
@rmanaem rmanaem removed their assignment Apr 5, 2023
@surchs
Copy link
Contributor

surchs commented Apr 19, 2023

@jarmoza @rmanaem: could you see if this can be closed directly?

@rmanaem
Copy link
Contributor

rmanaem commented Apr 19, 2023

I think so since both the save annotation button and the table have been removed.

@jarmoza
Copy link
Contributor Author

jarmoza commented Apr 20, 2023

Yes, both the components and methods involved in this bug have now been removed.

@jarmoza jarmoza closed this as completed Apr 20, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Review - Done in Neurobagel Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
annotation page download page usability Issue affecting user or developer experience.
Projects
Archived in project
Development

No branches or pull requests

3 participants