-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI should always reflect internal annotation state #128
Comments
Just noting - Began this task yesterday. |
This is blocked by #199 because there is no direct way to know the current mapping of a unique value. |
*Other than to find the raw value in the original data table |
We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 30 days. |
As a user, after I have annotated a column (and saved the annotation), whenever I navigate back to the annotation page (i.e. navigate away and go back), I want to see the stored annotations in the user interface, so that I can easily change any of them and don't have to redo all annotations if I just want to change one.
Tests:
Background:
At the moment, free form input fields on the annotation page are not two-way linked to the internal state. That is, I can provide a new annotation value in the field, but when I navigate away and come back, the text field will be empty / in it's default state, even though an annotated value exists in the internal state.
This is because at the moment we are treating the input fields like buttons and listen to their
@change
or@input
events, rather than using thev-model
directive as designed.There is a bit of work involved to get
v-model
to work (hence why it doesn't work yet), because we will have to use scoped slots in order to handle each value individually. We should write up the work that needs to happen and then implement so that a user will always see the internal annotation state when they look at the annotation interface!The text was updated successfully, but these errors were encountered: