Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create-neon: Support change in cargo diagnostics naming #1043

Closed
dherman opened this issue May 18, 2024 · 0 comments · Fixed by #1044
Closed

create-neon: Support change in cargo diagnostics naming #1043

dherman opened this issue May 18, 2024 · 0 comments · Fixed by #1044
Labels
bug create-neon

Comments

@dherman
Copy link
Collaborator

dherman commented May 18, 2024

An upcoming change in cargo canonicalizes crate names from kebab-case to camel_case. This was fixed for cargo-cp-artifact in #1039 but now that create-neon uses the new CLI, we needed a fix there too.

The new CLI was fixed in neon-bindings/neon-rs#58, so we just need create-neon to upgrade to use the new CLI version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug create-neon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(create-neon): Bump CLI version to 0.1.73 neon-bindings/neon
1 participant
@dherman