Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.21.x] GlobalLootModifierProvider does not preserve the order of inserted entries #1828

Open
Shadows-of-Fire opened this issue Jan 6, 2025 · 0 comments
Labels
1.21.1 Targeted at Minecraft 1.21.1 1.21.4 Targeted at Minecraft 1.21.4 bug A bug or error

Comments

@Shadows-of-Fire
Copy link
Contributor

The GLM provider does not record the order of inserted entries, meaning modders have no way to control the order of their GLMs from within their own mod when using datagen.

private final Map<String, WithConditions<IGlobalLootModifier>> toSerialize = new HashMap<>();

This HashMap should be a LinkedHashMap.

Realistically we should implement #697 but this is an issue with the current system as-is.

@Shadows-of-Fire Shadows-of-Fire added 1.21.1 Targeted at Minecraft 1.21.1 1.21.4 Targeted at Minecraft 1.21.4 bug A bug or error labels Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.1 Targeted at Minecraft 1.21.1 1.21.4 Targeted at Minecraft 1.21.4 bug A bug or error
Projects
None yet
Development

No branches or pull requests

1 participant