Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Player does not respect Grapher "ports" #2

Open
kirbysayshi opened this issue Mar 24, 2019 · 0 comments
Open

Player does not respect Grapher "ports" #2

kirbysayshi opened this issue Mar 24, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@kirbysayshi
Copy link
Contributor

"Ports" allow for control signals that are required by a node to process its audio:
https://github.com/spotify/NFGrapher/blob/36cb827667f580c68c5a28fdc2000afcde2bfcf1/smart-player-contract.json#L540-L562

Required for anything like sidechain compression. Right now the Player just assumes all inputs are audio for inclusion in the final output. Luckily no nodes right now require this, but a compressor is very useful.
@kirbysayshi kirbysayshi added the enhancement New feature or request label Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kirbysayshi