From 0c8dd5ff4b01d3484f476fcc0c6af763d1d46eee Mon Sep 17 00:00:00 2001 From: catcherwong Date: Tue, 15 Mar 2022 00:01:16 +0800 Subject: [PATCH 1/2] fix: naming with empty namespace --- src/Nacos/V2/Common/Constants.cs | 2 +- src/Nacos/V2/Naming/NacosNamingService.cs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Nacos/V2/Common/Constants.cs b/src/Nacos/V2/Common/Constants.cs index 877f93d..aadac42 100644 --- a/src/Nacos/V2/Common/Constants.cs +++ b/src/Nacos/V2/Common/Constants.cs @@ -2,7 +2,7 @@ { public class Constants { - public static string CLIENT_VERSION = "Nacos-CSharp-Client:v1.3.1"; + public static string CLIENT_VERSION = "Nacos-CSharp-Client:v1.3.2"; public const string ClientName = "NacosClient"; diff --git a/src/Nacos/V2/Naming/NacosNamingService.cs b/src/Nacos/V2/Naming/NacosNamingService.cs index be318a9..7f3489a 100644 --- a/src/Nacos/V2/Naming/NacosNamingService.cs +++ b/src/Nacos/V2/Naming/NacosNamingService.cs @@ -37,7 +37,7 @@ public NacosNamingService( { _logger = loggerFactory.CreateLogger(); _options = optionAccs.Value; - _namespace = _options.Namespace; + _namespace = string.IsNullOrWhiteSpace(_options.Namespace) ? Utils.UtilAndComs.DEFAULT_NAMESPACE_ID : _options.Namespace; this._changeNotifier = new InstancesChangeNotifier(); this._serviceInfoHolder = new ServiceInfoHolder(_logger, _namespace, _options, _changeNotifier); this._clientProxy = new NamingClientProxyDelegate(_logger, _namespace, _serviceInfoHolder, _options, _changeNotifier, clientFactory); From 4e4d50916a717f505f18317c784b1b909ade200d Mon Sep 17 00:00:00 2001 From: catcherwong Date: Tue, 15 Mar 2022 00:18:38 +0800 Subject: [PATCH 2/2] docs: release note --- docs/index.rst | 2 +- docs/releasenote/v1.3.1.rst | 2 +- docs/releasenote/v1.3.2.rst | 10 ++++++++++ 3 files changed, 12 insertions(+), 2 deletions(-) create mode 100644 docs/releasenote/v1.3.2.rst diff --git a/docs/index.rst b/docs/index.rst index a090dd2..213df3a 100644 --- a/docs/index.rst +++ b/docs/index.rst @@ -40,11 +40,11 @@ :hidden: :caption: Release Note - releasenote/v1.2.0 releasenote/v1.2.1 releasenote/v1.2.2 releasenote/v1.3.0 releasenote/v1.3.1 + releasenote/v1.3.2 .. toctree:: :maxdepth: 2 diff --git a/docs/releasenote/v1.3.1.rst b/docs/releasenote/v1.3.1.rst index bb86416..8d8460a 100644 --- a/docs/releasenote/v1.3.1.rst +++ b/docs/releasenote/v1.3.1.rst @@ -1,4 +1,4 @@ -v1.3.1 (Jan xth, 2022) 发布记录 +v1.3.1 (Jan 20th, 2022) 发布记录 ============================================= 1. [NAMING] Fix ServiceListRequest pageSize error diff --git a/docs/releasenote/v1.3.2.rst b/docs/releasenote/v1.3.2.rst new file mode 100644 index 0000000..e6e891d --- /dev/null +++ b/docs/releasenote/v1.3.2.rst @@ -0,0 +1,10 @@ +v1.3.2 (Mar 15th, 2022) 发布记录 +============================================= + +1. [NAMING] Fix QueryInstancesOfService error cluster param (#180 #181) +#. [NAMING] Fix Empty namespace issue (#187 #189) + +------------ + +1. [NAMING] 修复 QueryInstancesOfService 请求参数错误 (#180 #181) +#. [NAMING] 修复空命名空间默认值问题 (#187 #189) \ No newline at end of file