From dc2803520c701dc7141b24e67742406e3a5683b0 Mon Sep 17 00:00:00 2001 From: calixte Date: Mon, 22 Nov 2021 15:32:36 +0100 Subject: [PATCH] Copy-duplicat-info - Avoid to nag forever because a bug hasn't a cf_crash_signature field --- auto_nag/scripts/copy_duplicate_info.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/auto_nag/scripts/copy_duplicate_info.py b/auto_nag/scripts/copy_duplicate_info.py index e9097a4cf..ba9cf09a2 100644 --- a/auto_nag/scripts/copy_duplicate_info.py +++ b/auto_nag/scripts/copy_duplicate_info.py @@ -70,7 +70,7 @@ def handle_bug(self, bug, data): data[bugid] = { "id": bugid, "summary": self.get_summary(bug), - "signature": bug.get("cf_crash_signature", ""), + "signature": bug.get("cf_crash_signature", None), "dupe": str(bug["dupe_of"]), "product": bug["product"], "component": bug["component"], @@ -117,6 +117,10 @@ def compare(self, bugs, dups): dup = dups[dupid] bs = utils.get_signatures(info["signature"]) + if dup["signature"] is None: + # some bugs don't have a cf_crash_signature field... it's weird + # but it's life... + continue ds = utils.get_signatures(dup["signature"]) if not bs.issubset(ds): signatures[dupid] = bs - ds