-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support building with npm
#68
Comments
The complexity here is not in making the xpi-manifest repo change, but in making sure that we don't leave CI or any given supported repo broken in doing so. |
In some documentation it is suggested that the existence of |
@ianb xpi-manifest doesn't clone every repo when creating its graph, so it doesn't know what files are in the project. Doing so may slow things down. |
Additional information:
|
Currently, both CI and release builds assume we will build the xpi via
yarn build
. There are at least a couple repos where developers want npm building support (not sure if this isnpm build
ornpm run build
?).The actual line in question is here. That's super easy to change. We can key that off of
XPI_INSTALL_TYPE
or another env var. (If another env var, we should add a corresponding xpi-manifest key and surface that as an env var, like we do withXPI_INSTALL_TYPE
.We should:
active: false
to avoid needing to patch themThe text was updated successfully, but these errors were encountered: