Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix android crash on app launch after app upgrades #622

Closed
vharsh opened this issue Mar 7, 2023 · 4 comments
Closed

Fix android crash on app launch after app upgrades #622

vharsh opened this issue Mar 7, 2023 · 4 comments
Assignees
Labels
BLE-Sharing Related to BLE sharing mechanism bug Something isn't working MEC targeted for MEC triaged Triage completed
Milestone

Comments

@vharsh
Copy link
Member

vharsh commented Mar 7, 2023

Describe the bug

In most cases the app works as normal, but after a series of use-and-appUpgrades, the app fails to start and always crashes as soon as the app is launched by tapping on it's icon, no splash screen is visible, just the Android system dialog box pops up specifying that the app has crashed.

To Reproduce

  1. Install an older version of Inji app
  2. Use the app to transfer VCs
  3. Upgrade the app
  4. Repeat steps 1-3 until the app crashes on launch

I installed release apps from these release dates to reproduce this bug; 20th Feb --> 28th Feb --> 20th Feb --> 28th Feb --> 6th March.

Expected behavior

On app upgrades the app should not crash.

Actual behavior

After usage & upgrades of the app, the app fails to start and this is a known issue for a certain range of React native versions as documented here.

Add the screenshot of the profile page with commit id

The bug applies to all versions of Android app on Android 9, 10, 11 as documented by the issue on SoLoader repository

Smartphone:

This has been successfully reproduced on Nokia 6.1 Plus(Android 10, BLE 5.0). Since this bug is a react native issue, wallet & verifier details are not relevant here as the app fails to start. This is a React Native issue, so it applies to more devices.

Further relevant details:

React Native version: 0.64.4
Original issue: facebook/SoLoader#77

Logs:

android-onlaunch-crash.txt

@vharsh vharsh added bug Something isn't working triage This issue is pending confirmation and planning and should not be worked on yet labels Mar 7, 2023
@ravikp ravikp added triaged Triage completed and removed triage This issue is pending confirmation and planning and should not be worked on yet labels Mar 7, 2023
@ravikp ravikp added this to the 10th MAR 23 milestone Mar 7, 2023
@ravikp ravikp moved this to Development in MOSIP Inji issues tracking Mar 7, 2023
@ravikp ravikp added the MEC targeted for MEC label Mar 8, 2023
@vharsh
Copy link
Member Author

vharsh commented Mar 9, 2023

This bug was a known issue for certain ReactNative versions and has been fixed as recommended by community users. It has been tested against release builds of various versions on Android 10 with the Inji app being used and upgraded multiple times till the bug was reproduced(i.e. the app crashed on launch) and then when the fix-changeset build was used to successfully run the app.

PR for mosip/inji: #630

The PRs have been merged in 09-03-2023 Release and the latest commit id on mosip/inji/develop is fa142c6

@vharsh vharsh moved this from Development to Merged in MOSIP Inji issues tracking Mar 9, 2023
@Sujithbn Sujithbn moved this from Merged to QA (test) in MOSIP Inji issues tracking Mar 9, 2023
@Sujithbn Sujithbn added the BLE-Sharing Related to BLE sharing mechanism label Mar 14, 2023
@santhoshsunder
Copy link
Contributor

verified this issue on the new build, I tried to install 3 different old builds back again and again, just like @vharsh mentioned in above, the issue is not observed anymore, the task is able to close

Tested on :

device : pixel 6
ble : 5.2
android : 13

device : redmi k20 pro
ble : 5.0
android : 11

device : vivo y73
ble : 5.0
android : 12

MOSIP Version : 1.2.0.1
MOSIP server : qa-1201-b2.net
APP link : https://github.com/mosip/inji/actions/runs/4447486079

@vharsh
Copy link
Member Author

vharsh commented Mar 23, 2023

@Anushree09-N @santhoshsunder Can this issue be closed now?

@github-project-automation github-project-automation bot moved this from QA (test) to Merged in MOSIP Inji issues tracking Mar 23, 2023
@santhoshsunder
Copy link
Contributor

@vharsh the issue can be closed, issue is not replicating, hence closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLE-Sharing Related to BLE sharing mechanism bug Something isn't working MEC targeted for MEC triaged Triage completed
Projects
Status: Merged
Development

No branches or pull requests

7 participants