Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoCompletion doesn't work on MacOS #290

Open
rexim opened this issue Nov 2, 2016 · 6 comments
Open

AutoCompletion doesn't work on MacOS #290

rexim opened this issue Nov 2, 2016 · 6 comments

Comments

@rexim
Copy link
Member

rexim commented Nov 2, 2016

Moved from #288 (comment)

Original comment by @kuchenkruste:

It seems like that the NPE doesn't occur anymore. Sadly the autocompletion still doesn't work either (load <tab> simply does nothing). Maybe there is a problem with sym-links? I've moved the fatjar (as well as the std/ folder) to a separate folder, created a .sh script and linked /usr/local/bin/morganey to it.
It may be possible that I screwed up the path to the fatjar in the shell script. I'll check this out.

@rexim
Copy link
Member Author

rexim commented Nov 2, 2016

@kuchenkruste I'd suggest you to try the following scenario:

  • Go to the root of source code folder of Morganey
  • $ sbt assembly
  • $ java -jar target/scala-2.11/morganey-assembly-0.0.1.jar
  • λ> load <tab>

@rexim
Copy link
Member Author

rexim commented Nov 14, 2016

@kuchenkruste is this still reproducible?

@BjoernLoetters
Copy link

Sorry for my delayed response, my studies take up all my time. I'm really sorry.

Regarding to your question: Yes, it is still reproducible. I think the problem here is, that I've created a symbolic link to a shell script which itself executes the fat-jar. When executing the fat-jar directly everything works fine. I didn't look into the code, but it seems like there is something wrong with the part which is responsible for searching for the standard library.

@rexim
Copy link
Member Author

rexim commented Nov 18, 2016

@kuchenkruste cool! Thank you very much for the update! No need to be sorry. We all are busy with our own lifes and I completely understand that. I was just going through Morganey issues looking for something I could quickly close and decided to ping you just in case. :)

I wanna try to reproduce that on my Linux. We can probably convert that into a bug with formal reproduction instructions.

@rexim
Copy link
Member Author

rexim commented Nov 19, 2016

NixOS 16.03 couldn't reproduce

Morganey/ $ sbt assembly
Morganey/ $ cd ..
$ cat << EOF > morganey.sh
heredoc> #!/bin/sh
heredoc> 
heredoc> java -jar target/scala-2.11/morganey-assembly-0.0.1.jar $@
heredoc> EOF
$ chmod +x morganey.sh
$ ln -s morganey.sh morganey
$ cd Morganey
Morganey/ $ ../morganey
λ> load std. <TAB>
load std.list        load std.prelude     load std.common      load std.math.       load std.logic       load std.functions   

@rexim
Copy link
Member Author

rexim commented Jan 16, 2017

@kuchenkruste after merging #319 Morganey fully supports autocompletion of modules from jar. The fatjar is completly self-content. Please try to reproduce the problem again when you get a chance. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants