Skip to content
This repository has been archived by the owner on Nov 11, 2024. It is now read-only.

Attach running process #59

Closed
wants to merge 1 commit into from
Closed

Conversation

akihikodaki
Copy link
Contributor

Closes #6.

Copy link

@thaystg thaystg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, but why do we need to implement "attach" command, if it's doing exactly the same that "connect" command does?

@akihikodaki
Copy link
Contributor Author

I was not aware of connect command.

Well, maybe those who have used gdb before will look for attach command and may have misconception that the feature is not implemented. That is exactly my case. I think this command should be implemented as an alias or removed. Which do you prefer, or do you have another idea?

@thaystg
Copy link

thaystg commented Oct 9, 2019

I think that attach should be implemented to be used with PID as gdb.
But to avoid this misconception, we can put a message like:
"Attempts to attach to the given process ID.\n" +
"\n" +
"Currently unimplemented.\nUse connect command."
What do you think?

@alexrp
Copy link
Contributor

alexrp commented Oct 10, 2019

I think that attach should be implemented to be used with PID as gdb.

This was the original intention, but I never got around to implementing it this way because (at least at the time) that seemed fairly non-trivial and would probably have involved using Mono's general-purpose assembly attach mechanism: https://github.com/mono/mono/blob/master/mono/metadata/attach.c

It's quite possible the VSfM team figured out a better solution in the meantime though. I'm not up to date on the issue.

I have no objection to updating attach's help text to point to the connect command until it's actually implemented.

@akihikodaki
Copy link
Contributor Author

Anyway, this change for attach command is no longer relevant. I'll close this pull request.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement process attach support
3 participants