Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lunasvg v2.3.1 now available #4302

Closed
vomikan opened this issue Apr 21, 2022 · 4 comments
Closed

lunasvg v2.3.1 now available #4302

vomikan opened this issue Apr 21, 2022 · 4 comments
Assignees
@vomikan
Labels
enhancement fixed
Milestone
v1.5.15

Comments

@vomikan
Copy link
Member

vomikan commented Apr 21, 2022

https://github.com/sammycage/lunasvg/releases/tag/v2.3.1
@vomikan vomikan self-assigned this Apr 21, 2022
vomikan added a commit to vomikan/moneymanagerex that referenced this issue Apr 21, 2022
@vomikan
fix(moneymanagerex#4302): update
822756d
@whalley whalley changed the title unasvg v2.3.1 now available lunasvg v2.3.1 now available Apr 21, 2022
@whalley
Copy link
Member

whalley commented Apr 21, 2022

@vomikan Not going to get a chance to review this on MacOS for another week due to other commitments.

It should also be noted that wxWidgets from 3.1.6 includes native support for SVG handling via nanoSVG, see: https://docs.wxwidgets.org/trunk/classwx_bitmap_bundle.html. but as noted in #4301 there are issues with 3.1.6 on MacOS.

vomikan added a commit that referenced this issue Apr 26, 2022
@vomikan
Merge pull request #4303 from vomikan/master
ca66e1e 
fix(#4302): update
@vomikan vomikan added the fixed label Apr 26, 2022
@vomikan
Copy link
Member Author

vomikan commented Apr 26, 2022

Minor changes have been made in this library. This should not negatively affect the operation of the application on different platforms. We cannot replace this library in the near future. I think the update is appropriate.

@vomikan vomikan closed this as completed Apr 26, 2022
@vomikan vomikan added this to the v1.5.15 milestone Apr 26, 2022
@whalley
Copy link
Member

whalley commented May 2, 2022

I seem to be getting duotone image scaling issues with the latest lunasvg. See below

After lunasvg change
CleanShot 2022-05-03 at 00 13 15

Prior to lunasvg change:

CleanShot 2022-05-03 at 00 15 24

@whalley whalley reopened this May 2, 2022
@whalley
Copy link
Member

whalley commented May 2, 2022

Panic over.... Must have had something lying around. Did a clean build and it works fine.

@whalley whalley closed this as completed May 2, 2022
@whalley whalley mentioned this issue Jun 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vomikan vomikan

Labels
enhancement fixed
Projects
None yet
Milestone
v1.5.15
Development

No branches or pull requests
2 participants
@whalley @vomikan