Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor module structure and naming convention #6

Open
bosd opened this issue Apr 3, 2022 · 2 comments
Open

Refactor module structure and naming convention #6

bosd opened this issue Apr 3, 2022 · 2 comments

Comments

@bosd
Copy link

bosd commented Apr 3, 2022

Currently there are 2 modules in this repo, each of them have a lot of dependencies and data.
Some of the data is double. Proposal is to use common odoo practice and perform a clean up by adding a parent base module.

base_monero

The base module will define XMR currency and symbol.
To fix allow to use enough decimal places and optional integration with accounting let it depend on the oca module account_cryptocurrency
Sets up the monero journals.
also have the following dependencies:
account
queue_job
"external_dependencies": {"python": ["monero"]}
It will not depend on web. So it can be used on systems without website installed.

monero-rpc-odoo

monero-rpc-odoo rename to payment_monero
Depends on the base_monero module.

monero-rpc-odoo-pos

monero-rpc-odoo-pos rename to pos_payment_monero
Depends on the base_monero module.
Remove the field is_cryptocurrency, as it is unused.
(maybe implement a hook to recalulate the exchange rate.)
"category": "Accounting" to 'category': 'Sales/Point of Sale'

account_monero_transfer

Future module to be developed to initiate a monero payment from the odoo backend to a supplier?
Will also depend on base monero.
Depends on the base_monero module.

edit:
since the monero lib is used instead of monero-rpc.
Change the names to prevent confusion.

@bosd
Copy link
Author

bosd commented Apr 6, 2022

@AdriaGForgeFlow Since you're the author of the module account_cryptocurrency can you share your knowledge how to integrate monero with this module?

@bosd
Copy link
Author

bosd commented Apr 9, 2022

@JordiBForgeFlow your knowledge on this subject is appreciated :)

@bosd bosd mentioned this issue Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant