Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix asset-name upstream #145

Merged
merged 1 commit into from
Oct 31, 2023
Merged

🐛 Fix asset-name upstream #145

merged 1 commit into from
Oct 31, 2023

Conversation

czunker
Copy link
Contributor

@czunker czunker commented Oct 31, 2023

This set the asset-name also upstream.

Fixes #137

@czunker
🐛 Fix asset-name upstream
95a2503 
This set the asset-name also upstream.

Fixes #137

Signed-off-by: Christian Zunker <[email protected]>
@czunker
Copy link
Contributor Author

czunker commented Oct 31, 2023

As test, I added the cz-test suffix here: https://github.com/mondoohq/packer-plugin-cnspec/blob/main/examples/packer-docker/docker-ubuntu.pkr.hcl#L44

This shows up during scan:

    mondoo-docker-ubuntu-2204-secure-base.docker.ubuntu: Scanned 1 asset
    mondoo-docker-ubuntu-2204-secure-base.docker.ubuntu: 
    mondoo-docker-ubuntu-2204-secure-base.docker.ubuntu: Ubuntu 22.04.3 LTS
    mondoo-docker-ubuntu-2204-secure-base.docker.ubuntu:     A mondoo-gcp-ubuntu-2004-secure-base-20231031050657-cz-test

And upstream:
Screenshot from 2023-10-31 06-09-16

chris-rock
chris-rock approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @czunker

@chris-rock chris-rock merged commit 88c3c01 into main Oct 31, 2023
6 checks passed
@chris-rock chris-rock deleted the christian/fix_137 branch October 31, 2023 07:51
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chris-rock chris-rock chris-rock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

asset-name configuration is not sent back to Mondoo Platform
2 participants
@czunker @chris-rock