Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): Add api for getting a single subscription #998

Merged
merged 5 commits into from
Mar 13, 2024

Conversation

Tetrergeru
Copy link
Member

@Tetrergeru Tetrergeru commented Mar 13, 2024

Add handler in api to get single subsription by id. Only user with rights for subscription cah use this handler, others will get 403 Forbidden

@Tetrergeru Tetrergeru requested a review from a team as a code owner March 13, 2024 10:28
kissken
kissken previously approved these changes Mar 13, 2024
@Tetrergeru Tetrergeru changed the title Add api for getting a single subscription feat(api): Add api for getting a single subscription Mar 13, 2024
@Tetrergeru
Copy link
Member Author

/build

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 6.25000% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 67.74%. Comparing base (da72678) to head (1769155).

❗ Current head 1769155 differs from pull request most recent head 41f78a3. Consider uploading reports for the commit 41f78a3 to get more accurate results

Files Patch % Lines
api/handler/subscription.go 10.00% 9 Missing ⚠️
api/controller/subscription.go 0.00% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #998      +/-   ##
==========================================
- Coverage   67.82%   67.74%   -0.09%     
==========================================
  Files         208      208              
  Lines       11939    11955      +16     
==========================================
+ Hits         8098     8099       +1     
- Misses       3343     3358      +15     
  Partials      498      498              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

almostinf
almostinf previously approved these changes Mar 13, 2024
@Tetrergeru Tetrergeru merged commit 6724bf7 into master Mar 13, 2024
5 checks passed
@Tetrergeru Tetrergeru deleted the feature/get-single-subscription branch March 13, 2024 10:53
Copy link

Build and push Docker images with tag: 2024-03-13.6724bf7

1 similar comment
Copy link

Build and push Docker images with tag: 2024-03-13.6724bf7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants