Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(senders): add ability to use template webhook body and custom headers #995

Merged
merged 8 commits into from
Apr 1, 2024
Merged

feat(senders): add ability to use template webhook body and custom headers #995

merged 8 commits into from
Apr 1, 2024

Conversation

almostinf
Copy link
Member

@almostinf almostinf commented Feb 21, 2024 •
edited
Loading

Add ability to use template body and custom headers

I divided the functionality in the templating package to work with filling in the body of the webhook and to work with filling in the description of the trigger

Added ability to set templated body in webhook config and set custom headers

@almostinf almostinf requested a review from a team as a code owner February 21, 2024 13:07
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 46.15385% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 67.80%. Comparing base (8683bef) to head (61abe52).

❗ Current head 61abe52 differs from pull request most recent head 869eb22. Consider uploading reports for the commit 869eb22 to get more accurate results

Files Patch % Lines
datatypes.go 0.00% 10 Missing ⚠️
senders/webhook/request.go 50.00% 5 Missing ⚠️
templating/webhook.go 0.00% 5 Missing ⚠️
api/dto/triggers.go 0.00% 2 Missing ⚠️
api/handler/team.go 0.00% 2 Missing ⚠️
senders/webhook/webhook.go 33.33% 1 Missing and 1 partial ⚠️
templating/templating.go 75.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@                  Coverage Diff                   @@
##           feat/scale-senders     #995      +/-   ##
======================================================
- Coverage               67.87%   67.80%   -0.08%     
======================================================
  Files                     208      210       +2     
  Lines                   11952    11975      +23     
======================================================
+ Hits                     8113     8120       +7     
- Misses                   3341     3356      +15     
- Partials                  498      499       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@almostinf almostinf changed the title feat(senders): add ability to use template webhook body feat(senders): add ability to use template webhook body and custom headers Feb 22, 2024
@almostinf
Copy link
Member Author

/build

1 similar comment
@almostinf
Copy link
Member Author

/build

kissken
kissken reviewed Feb 29, 2024
View reviewed changes
api/dto/triggers.go Outdated Show resolved Hide resolved
@almostinf almostinf requested a review from kissken February 29, 2024 10:33
@almostinf
Copy link
Member Author

/build

Tetrergeru
Tetrergeru reviewed Mar 5, 2024
View reviewed changes
api/dto/triggers.go Outdated Show resolved Hide resolved
@almostinf almostinf force-pushed the feat/scale-senders branch from e530d75 to 8550e29 Compare March 11, 2024 10:17
@almostinf almostinf force-pushed the feat/add-templating-to-senders branch from ee35940 to 72431eb Compare March 11, 2024 13:40
@almostinf almostinf requested a review from Tetrergeru March 11, 2024 13:40
kissken
kissken reviewed Mar 13, 2024
View reviewed changes
datatypes.go Show resolved Hide resolved
@almostinf
Copy link
Member Author

/build

@almostinf
Copy link
Member Author

/build

@almostinf almostinf requested review from Tetrergeru and kissken March 21, 2024 12:15
@almostinf
Copy link
Member Author

/build

@github-actions GitHub Actions
Copy link

Build and push Docker images with tag: feat-add-templating-to-senders.2024-03-22.7a2bf1d

2 similar comments
@github-actions GitHub Actions
Copy link

Build and push Docker images with tag: feat-add-templating-to-senders.2024-03-22.7a2bf1d

@github-actions GitHub Actions
Copy link

Build and push Docker images with tag: feat-add-templating-to-senders.2024-03-22.7a2bf1d

@github-actions GitHub Actions
Copy link

Build and push Docker images with tag: feat-add-templating-to-senders.2024-03-22.7a2bf1d

@almostinf almostinf merged commit 9a5cbaa into feat/scale-senders Apr 1, 2024
5 checks passed
@almostinf almostinf deleted the feat/add-templating-to-senders branch April 1, 2024 10:01
@almostinf almostinf mentioned this pull request Apr 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tetrergeru Tetrergeru Tetrergeru approved these changes

@kissken kissken kissken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@almostinf @codecov-commenter @kissken @Tetrergeru