feat(notifier): fix sending unwanted notifications on muted and deleted triggers and muted metrics #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yed_time from configs
…ake TxPipelined in place of Pipelined
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #943 +/- ##
==========================================
+ Coverage 68.94% 69.44% +0.49%
==========================================
Files 196 196
Lines 11038 11208 +170
==========================================
+ Hits 7610 7783 +173
+ Misses 2983 2962 -21
- Partials 445 463 +18
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
This was referenced Oct 24, 2023
msaf1980
previously approved these changes
Oct 26, 2023
kissken
previously approved these changes
Oct 30, 2023
Tetrergeru
reviewed
Nov 3, 2023
Tetrergeru
previously approved these changes
Nov 7, 2023
almostinf
changed the title
Tetrergeru
approved these changes
Nov 13, 2023
|
/build |
|
Build and push Docker images with tag: 2023-11-13.ed1f263 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add notifier config
Add description of notification config, in detail:
delayed_time- if the difference between notification sending time (timestamp) and creation time (created_at) is greater than this time, then the notification is considered delayed, otherwise it is considered not delayedtransaction_timeout- timeout time between transactions infetchNotificationstransaction_max_retries- maximum number of transactions infetchNotificationstransaction_heuristic_limit- limit, if exceeded, all notifications will be fetched from the database.Divided 1 big PR into 3 parts, here are the rest: