New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): query parameters to trigger events #1064

Merged

almostinf merged 22 commits into moira-alert:master from AleksandrMatsko:feat/query-params-to-event-history

Aug 14, 2024

Member

AleksandrMatsko commented Jul 23, 2024 •

edited

Loading

Add some query parameters to `/api/event/{trigger_id}`

Offered query parameters are:

from - start of time range
to - end of time range
metric - regular expression which will be used on NotificationEvent.Metric field
states - separated string of states, separator is ','

AleksandrMatsko added 6 commits

July 18, 2024 19:33


          feat: raw middlewares and db method refactor

0ea036c


          refactor: parsing and using query params

518cf9c


          fix: context key for states

d5368f4


          fix: api to work

d5d75ca


          fix: broken tests

fc2f714


          test: for middleware

57c14f2

AleksandrMatsko marked this pull request as ready for review

July 23, 2024 12:41

AleksandrMatsko requested a review from a team as a code owner

July 23, 2024 12:41

almostinf reviewed

View reviewed changes

api/handler/event.go Outdated Show resolved Hide resolved

almostinf reviewed

View reviewed changes

api/handler/event.go Outdated Show resolved Hide resolved

almostinf reviewed

View reviewed changes

api/handler/event.go Outdated Show resolved Hide resolved

almostinf reviewed

View reviewed changes

api/handler/event.go Outdated Show resolved Hide resolved

almostinf reviewed

View reviewed changes

api/handler/trigger.go Outdated Show resolved Hide resolved

almostinf reviewed

View reviewed changes

api/handler/trigger.go Outdated Show resolved Hide resolved

almostinf reviewed

View reviewed changes

api/middleware/middleware.go Outdated Show resolved Hide resolved

almostinf reviewed

View reviewed changes

database/redis/notification_event.go Outdated Show resolved Hide resolved

almostinf reviewed

View reviewed changes

database/redis/notification_event.go Outdated Show resolved Hide resolved

almostinf reviewed

View reviewed changes

database/redis/notification_event.go Outdated Show resolved Hide resolved

almostinf reviewed

View reviewed changes

state.go Outdated Show resolved Hide resolved

AleksandrMatsko added 5 commits

July 24, 2024 11:24


          refactor: namings, move values to vars

75dad93


          refactor: IsValid for State

73d2761


          refactor: move filtering to controller

dfd63eb


          test: try to fix controller test

cb4867c


          test: for controller

8aacada

AleksandrMatsko requested a review from almostinf

July 24, 2024 12:25


          refactor: use ContextKey for keys in middleware

6ada76d

kissken reviewed

View reviewed changes

api/controller/events.go Show resolved Hide resolved

kissken reviewed

View reviewed changes

api/handler/trigger.go Outdated Show resolved Hide resolved

kissken reviewed

View reviewed changes

api/middleware/context_test.go Outdated Show resolved Hide resolved

kissken reviewed

View reviewed changes

api/middleware/context_test.go

+              func TestMetricProviderMiddleware(t *testing.T) {
+              	Convey("checking correctness of parameter", t, func() {
+              		responseWriter := httptest.NewRecorder()
+              		defaultMetric := ".*"

Member

kissken Jul 25, 2024

у тебя вроде бы где-то была на такое публичная константа

Member Author

AleksandrMatsko Jul 25, 2024 •

edited

Loading

она не публичная, в handler

almostinf reviewed

View reviewed changes

api/handler/event.go Outdated Show resolved Hide resolved

Tetrergeru reviewed

View reviewed changes

api/controller/events.go Outdated Show resolved Hide resolved

Tetrergeru reviewed

View reviewed changes

api/handler/constants.go Outdated Show resolved Hide resolved

Tetrergeru reviewed

View reviewed changes

api/handler/trigger.go Show resolved Hide resolved

Tetrergeru reviewed

View reviewed changes

api/middleware/context.go Outdated Show resolved Hide resolved


          fix: remove unnecessary continue, comments

104320d

AleksandrMatsko requested review from Tetrergeru and almostinf

July 29, 2024 08:55

almostinf reviewed

View reviewed changes

api/handler/event.go Outdated Show resolved Hide resolved


          refactor: change swagger comments

35af5cf

Member

EduardZaydler commented Jul 30, 2024

/build

AleksandrMatsko requested a review from almostinf

July 30, 2024 09:31

almostinf previously approved these changes

View reviewed changes

AleksandrMatsko added 4 commits

July 31, 2024 16:48


          merge 'master' into feat/query-params-to-event-history

7e6893f


          merge master into feat/query-params-to-event-history

8d68c29


          refactor: rename middlewares

67067a3


          refactor: try to fix api spec

01f1114

AleksandrMatsko dismissed almostinf’s stale review via

01f1114

August 8, 2024 03:56

AleksandrMatsko requested a review from almostinf

August 8, 2024 04:04

AleksandrMatsko and others added 3 commits

August 8, 2024 12:19


          style: add new lines between code blocks

dc5226d


          Merge branch 'master' into feat/query-params-to-event-history

fa0b578


          fix: close ) for const

4beb56c

almostinf approved these changes

View reviewed changes

Tetrergeru approved these changes

View reviewed changes

Member

almostinf commented Aug 13, 2024

/build

almostinf merged commit 8560887 into moira-alert:master

6 checks passed

github-actions bot commented Aug 14, 2024

Build and push Docker images with tag: 2024-08-14.8560887

1 similar comment

github-actions bot commented Aug 14, 2024

Build and push Docker images with tag: 2024-08-14.8560887

almostinf added a commit that referenced this pull request


          Revert "feat(api): query parameters to trigger events (#1064)"

424b551

This reverts commit 8560887.

almostinf added a commit that referenced this pull request


          Revert "feat(api): query parameters to trigger events (#1064)" (#1071)

6683a4a

This reverts commit 8560887.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet